Issues with Dockerizing nginx with microgateway #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Avoid hardcoding port numbers in ngnix file since they should be obtained via docker -Modified the README.md file to deploy the microgateway starter script in the root directory instead of the test directory. Its easier to run the microgateway via docker from a known location in the root directory vs previous test directory -Added openssl to the ngnix Dockerfile since its needed as part of the Docker build
tonyffrench
approved these changes
Jun 6, 2017
This was referenced Jun 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Avoid hardcoding port numbers in ngnix file since they should be
obtained via docker
-Modified the README.md file to deploy the microgateway starter script
in the root directory instead of the test directory. Its easier to run
the microgateway via docker from a known location in the root directory
vs previous test directory
-Added openssl to the ngnix Dockerfile since its needed as part of the
Docker build