Allow TS variables to be documented #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimks
reviewed
May 4, 2018
test/ts-parser.test.js
Outdated
| expect(parsedData.constructs.map(function(c) { | ||
| return c.node.name; | ||
| })).to.eql(['param.Message', 'param.path', | ||
| 'Greeter', 'PathParameterValues']); | ||
| 'Greeter', 'PathParameterValues', 'greeter']); |
There was a problem hiding this comment.
Why do we also not check for the namespace param?
There was a problem hiding this comment.
Namespace param has become a prefix for its members.
There was a problem hiding this comment.
So it's impossible to generate docs based on the api docs directly on top of the namespace currently, right?
shimks
approved these changes
May 4, 2018
|
@shimks I have improved how |
For example:
export namespace a {
export const X = 1;
export const Y = 2;
}
export const B = 'b';
shimks
approved these changes
May 7, 2018
|
This is awesome, thank you @raymondfeng 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example:
Description
Related issues
Checklist
guide