Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Piwik code to body so HTML validates #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Move Piwik code to body so HTML validates #9

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented May 30, 2017

strugee
strugee requested changes May 30, 2017
View reviewed changes
Copy link
Owner

@strugee strugee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the problem here is the <noscript> tag in <head>.

Instead of moving everything down to the bottom of the HTML, I think it'd be better to move it to right after the opening <body>.

@ghost
Copy link
Author

ghost commented May 31, 2017 •
edited by ghost
Loading

So the problem here is the <noscript> tag in <head>.

Not quite :)

The <noscript> element is valid in <head>. The problem is with the <p> element, which is not valid in <head>.

Instead of moving everything down to the bottom of the HTML, I think it'd be better to move it to right after the opening <body>.

I would advise against this, for the reasons given here.

If, having considered my remarks above, you still feel the same way as you did beforehand, please let me know and I will edit this PR's commit to more closely follow your preference :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@strugee