Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use public_web website folder (e.g. built) for imserver jsonpath because /website is never updated #4

Merged
merged 1 commit into from
Jun 3, 2021
Merged

Use public_web website folder (e.g. built) for imserver jsonpath because /website is never updated #4

merged 1 commit into from
Jun 3, 2021

Conversation

ineffyble
Copy link
Member

No description provided.

AlexCPU
AlexCPU approved these changes Jun 3, 2021
View reviewed changes
Copy link
Collaborator

@AlexCPU AlexCPU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that's a good point. We might have missed a portal update based on how old that content is... Oh well, this'll fix it when it deploys.

@AlexCPU AlexCPU merged commit 8e04a6e into master Jun 3, 2021
@AlexCPU AlexCPU deleted the fix/imserver-json-path branch June 3, 2021 07:55
@ineffyble
Copy link
Member Author

Yep, that's a good point. We might have missed a portal update based on how old that content is... Oh well, this'll fix it when it deploys.

I don't think we did miss a portal update, or we'd have had more complaints.

@AlexCPU
Copy link
Collaborator

AlexCPU commented Jun 3, 2021

I don't think we did miss a portal update, or we'd have had more complaints.

I didn't think so, but the files in static were dated August last year, and I thought the portal update was more recent than that.

@ineffyble
Copy link
Member Author

@AlexCPU Ah, but the update in November probably only included crew released before August, so we snuck by.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexCPU AlexCPU AlexCPU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ineffyble @AlexCPU