Dev 2.0 #473
Merged
Dev 2.0 #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying website with
|
| Latest commit: |
0d5784d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e0835237.website-i3mu.pages.dev |
| Branch Preview URL: | https://dev-2-0.website-i3mu.pages.dev |
added 29 commits
February 9, 2024 07:49
Also add ability for player to reset all persisted prefs.
Moves crew series check to fix improper filtering of crew without a series (i.e. Mirror Data). Adds description to Behold page. Adds parentheses around proficiency in classic presenter, to match proficiency formatting elsewhere.
Sets voyage telemetry preference to optIn by default. Also corrects one artifact of previous preference name (optOut => optIn).
Reorganizes voyage page code and adds some debugging to continue the hunt for a voyage rollover fix. Specifically breaks up code so that the initial page follows this flow: 1) VoyagePage (wait for core, allow player input) 2) VoyageSetup (consolidating all player listeners here to initialize voyage config, active voyage id, and active events in a single pass) 3) ActiveVoyageSetup (player only) and CalculatorSetup (roster picker and calculator) This *might* address the voyage rollover bug, as the consolidation of player listeners will more consistently pick up player data changes than the existing code. Renames some functions and variables for clarity. Adds explicit typings to some variables. Adds debugging for voyage config init (disable for production).
Disables debugging in datacontext. Toggle DC_DEBUGGING to re-enable.
Also enables script for gatsby clean (i.e. `run clean` to clear out gatsby .cache and public folders).
Frozen crew need an id for proper voyage recommendations. Before the switch to archetype_id for allCrew and active crew, we used a fakeId for all rosterCrew (including frozen crew). Now the id is once again properly set for frozen crew, only this time we'll also use archetype_id.
Reverting to the intended negative id for frozen crew, but now making the original calc match crew id by *signed* int instead of unsigned. This change might have other unintended consequences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 2.0 Will Include new Menus, Layouts, and Data Contexts