Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinkPeaks with a single gene #629

Closed
XinWang19 opened this issue May 19, 2021 · 1 comment
Closed

LinkPeaks with a single gene #629

XinWang19 opened this issue May 19, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@XinWang19
Copy link

XinWang19 commented May 19, 2021

Hi,
When I performed LinkPeaks with a single gene name like:

LinkPeaks(
object = seurat.obj,
peak.assay = "ATAC",
expression.assay = "RNA",
genes.use = "INS")

It returned:

No peaks fall within distance threshold 
Have you set the proper genome and seqlevelsStyle for ATAC assay?"

I found the problem is caused by line 51 and 57. When genes.use is a single character, the expression.data will become a vector without a row.name.

expression.data <- expression.data[genes.keep, ]
genes <- rownames(x = expression.data)

@XinWang19 XinWang19 added the bug Something isn't working label May 19, 2021
@timoast
Copy link
Collaborator

timoast commented May 19, 2021

Thanks for reporting, this should now be fixed on the develop branch. See installation instructions here: https://satijalab.org/signac/articles/install.html#development-version-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants