Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing effects wav files #9

Open
JackCA opened this issue Apr 25, 2014 · 3 comments
Open

missing effects wav files #9

JackCA opened this issue Apr 25, 2014 · 3 comments

Comments

@JackCA
Copy link
Contributor

JackCA commented Apr 25, 2014

The reverb() method looks for files that don't exist in the repository, are they supposed to be loaded another way?

@stuartmemo
Copy link
Owner

So, ideally you should be able to add your own file to create a reverb node, but it would also be nice to have some pre-included once. Adding the files to the repo would make setup more complicated or a bigger download to those who don't care about using the reverbs. But, it would be really nice to have them out the box wouldn't it?

What do you think?

@stuartmemo
Copy link
Owner

CC'ing you just in case you weren't notified. @JackCA

@JackCA
Copy link
Contributor Author

JackCA commented Apr 27, 2014

Perhaps there is a solution that doesn't require the external files at all? Have you seen: https://github.com/web-audio-components/simple-reverb?

This simple reverb could be used in conjunction with external files as well. There are also a few other components in that project that may help?

I'm currently working on getting jasmine running in the command line so we can setup Travis CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants