New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Student voice: Import mid-year survey, show on profile notes #2379

Merged
merged 11 commits into from Jan 29, 2019

Conversation

Projects
None yet
2 participants
@kevinrobinson
Copy link
Contributor

kevinrobinson commented Jan 29, 2019

Who is this PR for?

HS students, educators

What problem does this PR fix?

Mid-year student voice surveys started coming in.

What does this PR do?

Adds mid-year student voice surveys to profile notes. Adds ImportedForm for holding student voice surveys (eg, Q2 self-reflection, maybe student meeting, maybe transition notes), and includes them in profile notes.

This doesn't update the insights box, or make these visible on the home page feed.

Screenshot (if adding a client-side feature)

screen shot 2019-01-28 at 10 03 03 pm

Checklists

Which features or pages does this PR touch?

  • Student Profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here
@studentinsights-bot

This comment has been minimized.

Copy link

studentinsights-bot commented Jan 29, 2019

@kevinrobinson, this looks like it might be worth double-checking! @kevinrobinson might be able to help.

@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Jan 29, 2019

selfie

@kevinrobinson kevinrobinson merged commit 0f2a594 into master Jan 29, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@kevinrobinson kevinrobinson deleted the feature/student-voice-mid-year branch Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment