Fix issue, when message is object in Accounts.ui.FormMessage #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don`t now, what happend and in witch version of meteor. But I`ve had troubles with meteor/std:accounts-ui and zetoff:accounts-material-ui It`s fast simple fix, checked on meteor 1.4.1 and 1.4.2
lawrentiy
changed the title
|
@timbrandin seems a legit fix. If you are happy I'll merge it. |
|
I'm not sure what's the issue here. It feels strange that the message sometimes is an object and sometimes a string. Could we investigate this further before merging it? |
|
@lawrentiy |
|
I'm merging this for the reason that it doesn't affect any current behavior, just adding support for the strange situation when the message is of type object. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don
t now, what happend and in witch version of meteor. But Ive had troubles withmeteor/std:accounts-ui
and
zetoff:accounts-material-ui
It`s fast simple fix, checked on meteor 1.4.1 and 1.4.2