Add Markdown util and convert all sections #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to write our articles in markdown in React. The code is adapted from react-markings: https://github.com/Thinkmill/react-markings
kitten
changed the title
mxstbr
approved these changes
Aug 27, 2017
This is to trigger a stage.now.sh build and see if it works.
Closed
|
Here is a deploy of this branch: https://styled-components-docs-huxzgkpejt.now.sh |
|
@mxstbr uglify is failing :) probably something minor. I’ll take a look later and fix it. Just got back from some short holidays today |
|
@mxstbr Done and should be ready to merge 🚀 Edit: Seems that the replacement has caused some bugs somehow |
kitten
force-pushed
the
refactor/markdown
branch
from
177a508
to
05be150
Compare
Closed
kitten
changed the title
|
Let's ship this to avoid it getting hopelessly out of date?! |
|
Let's ship this to avoid it getting hopelessly out of date?! |
|
Awesomeeee!!! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I adapted react-markings for our components: https://github.com/Thinkmill/react-markings
It should actually work better for us than converting everything to Gatsby right now, and at the same time will make the task of translating everything a lot smoother probably. Not to mention the connected refactor and redesign.
It should be relatively straightforward, apart from the manual labour that's in translating everything to markdown :(
Edit: Not building with Uglify / build task right now due to an UglifyJS bug