Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Avoid compiling spec files when publishing #1515

Merged
merged 1 commit into from
Jan 9, 2020

Conversation

elevatebart
Copy link
Collaborator

When running npm run compile all spec.ts and tsx files are compiled into the lib folder which result in publishing tests to npm.

I remove this compilation, to make the command faster and avoid conflicts with other libraries.

@styleguidist-bot
Copy link
Collaborator

Warnings
⚠️

Changes were made to package.json, but not to package-lock.json.

If you’ve changed any dependencies (added, removed or updated any packages), please run npm install and commit changes in package-lock.json file. Make sure you’re using npm 5+.

Generated by 🚫 dangerJS against a301dff

@elevatebart
Copy link
Collaborator Author

Hey @sapegin, do you mind if I merge this one ?

Copy link
Member

@sapegin sapegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, go ahead! And thanks ⛺️

@elevatebart elevatebart merged commit ed438cb into master Jan 9, 2020
@elevatebart elevatebart deleted the build-avoid-publishing-specs branch January 9, 2020 12:58
@styleguidist-bot
Copy link
Collaborator

🎉 This PR is included in version 10.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants