Change default serverHost to 0.0.0.0 #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to connect from outside their local machines
|
I would say it could be a minor update as it shouldn't break existing setups. |
Codecov Report
@@ Coverage Diff @@
## master #374 +/- ##
=======================================
Coverage 92.57% 92.57%
=======================================
Files 74 74
Lines 1051 1051
Branches 223 223
=======================================
Hits 973 973
Misses 78 78
Continue to review full report at Codecov.
|
|
I have no opinion but I welcome this change because this is exactly how my setup works :) |
sapegin
added a commit
that referenced
this pull request
Apr 23, 2017
## New features ### React 15.5 compatibility No warnings when running with React 15.5. (#389 by @ldabiralai, @kulakowka) ### New config option to change Buble configuration New config option [compilerConfig](https://github.com/styleguidist/react-styleguidist/blob/master/docs/Configuration.md#compilerconfig). (#392 by @dylanmoz) ### Change default dev server host to 0.0.0.0 This allows users to connect from outside their local machines. (#374 by @Knorcedger) ## Bug fixes * Pass resolver and handlers to `propsParser` (#377 by @stepancar) * Use `[name]` in output filenames (#381 by @jskeate) * Show actual glob patterns on welcome screen (#387). * Show correct types in config validation errors (for example do not show `null` as `object`). * Do not print clean-webpack-plugin log messages. * Allow working without webpack config.
sapegin
added a commit
that referenced
this pull request
Apr 23, 2017
## New features ### React 15.5 compatibility No warnings when running with React 15.5. (#389 by @ldabiralai, @kulakowka) ### New config option to change Buble configuration New config option [compilerConfig](https://github.com/styleguidist/react-styleguidist/blob/master/docs/Configuration.md#compilerconfig). (#392 by @dylanmoz) ### Change default dev server host to 0.0.0.0 This allows users to connect from outside their local machines. (#374 by @Knorcedger) ## Bug fixes * Pass resolver and handlers to `propsParser` (#377 by @stepancar) * Use `[name]` in output filenames (#381 by @jskeate) * Show actual glob patterns on welcome screen (#387). * Show correct types in config validation errors (for example do not show `null` as `object`). * Do not print clean-webpack-plugin log messages. * Allow working without webpack config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to connect from outside their local machines
Resolves #373