Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 15.5 & Prop type updates #389

Merged
merged 3 commits into from
Apr 12, 2017
Merged

React 15.5 & Prop type updates #389

merged 3 commits into from
Apr 12, 2017

Conversation

ldabiralai
Copy link
Collaborator

This updates to using prop-types package and changes react versions to 15.5

@sapegin
Copy link
Member

sapegin commented Apr 12, 2017

Duplicate of #388.

@sapegin sapegin closed this Apr 12, 2017
@ldabiralai
Copy link
Collaborator Author

Whoops!

@sapegin sapegin reopened this Apr 12, 2017
@sapegin
Copy link
Member

sapegin commented Apr 12, 2017

We have two PRs for the same thing: one has mysterious merge conflicts and one has mysterious CI failures (this one, it also seems more complete). So I’ll try to merge this one and fix the CI.

@ldabiralai
Copy link
Collaborator Author

@sapegin I believe the tests are failing due to Enzyme issues. It's waiting on enzymejs/enzyme#876 to be released.

Sorry, forgot to mention that in my initial PR description.

@sapegin
Copy link
Member

sapegin commented Apr 12, 2017

They are going to make a release soon so I’d wait a bit.

@sapegin sapegin merged commit 01be4bb into styleguidist:master Apr 12, 2017
@sapegin
Copy link
Member

sapegin commented Apr 12, 2017

It actually completely breaks Styleguidist because of reactjs/react-docgen#171, so I’m reverting this for now.

sapegin added a commit that referenced this pull request Apr 12, 2017
sapegin added a commit that referenced this pull request Apr 12, 2017
@sapegin sapegin mentioned this pull request Apr 12, 2017
@sapegin
Copy link
Member

sapegin commented Apr 12, 2017

Waiting for reactjs/react-docgen#172

This was referenced Apr 13, 2017
sapegin added a commit that referenced this pull request Apr 14, 2017
@sapegin
Copy link
Member

sapegin commented Apr 14, 2017

Finally I could make it work ;-|

@ldabiralai
Copy link
Collaborator Author

Awesome, thanks! 👍

sapegin added a commit that referenced this pull request Apr 23, 2017
## New features

### React 15.5 compatibility

No warnings when running with React 15.5.

(#389 by @ldabiralai, @kulakowka)

### New config option to change Buble configuration

New config option [compilerConfig](https://github.com/styleguidist/react-styleguidist/blob/master/docs/Configuration.md#compilerconfig).

(#392 by @dylanmoz)

### Change default dev server host to 0.0.0.0

This allows users to connect from outside their local machines.

(#374 by @Knorcedger)

## Bug fixes

* Pass resolver and handlers to `propsParser` (#377 by @stepancar)
* Use `[name]` in output filenames (#381 by @jskeate)
* Show actual glob patterns on welcome screen (#387).
* Show correct types in config validation errors (for example do not show `null` as `object`).
* Do not print clean-webpack-plugin log messages.
* Allow working without webpack config.
sapegin added a commit that referenced this pull request Apr 23, 2017
## New features

### React 15.5 compatibility

No warnings when running with React 15.5.

(#389 by @ldabiralai, @kulakowka)

### New config option to change Buble configuration

New config option [compilerConfig](https://github.com/styleguidist/react-styleguidist/blob/master/docs/Configuration.md#compilerconfig).

(#392 by @dylanmoz)

### Change default dev server host to 0.0.0.0

This allows users to connect from outside their local machines.

(#374 by @Knorcedger)

## Bug fixes

* Pass resolver and handlers to `propsParser` (#377 by @stepancar)
* Use `[name]` in output filenames (#381 by @jskeate)
* Show actual glob patterns on welcome screen (#387).
* Show correct types in config validation errors (for example do not show `null` as `object`).
* Do not print clean-webpack-plugin log messages.
* Allow working without webpack config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants