Add logging for handled errors in Preview #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #431 +/- ##
==========================================
- Coverage 94.24% 94.16% -0.09%
==========================================
Files 78 78
Lines 1113 1114 +1
Branches 246 246
==========================================
Hits 1049 1049
- Misses 60 61 +1
Partials 4 4
Continue to review full report at Codecov.
|
sapegin
requested changes
May 6, 2017
| @@ -129,6 +129,9 @@ export default class Preview extends Component { | |||
| this.setState({ | |||
| error: err.toString(), | |||
| }); | |||
|
|
|||
| // eslint-disable-next-line | |||
| console.error(err); | |||
There was a problem hiding this comment.
// eslint-disable-line no-console would be more explicit.
nkt
force-pushed
the
fix/log-preview-errors
branch
from
8b90c24
to
0cbd7d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes easier debugging.
Before this change you can't understand why and how did you get an error
After merge, developer would be able to discover errors in console: