Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New bug report form #6

Merged
merged 9 commits into from
Oct 28, 2021
Merged

New bug report form #6

merged 9 commits into from
Oct 28, 2021

Conversation

ybiquitous
Copy link
Member

@ybiquitous ybiquitous commented Oct 28, 2021

@ybiquitous ybiquitous marked this pull request as ready for review October 28, 2021 16:10
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ybiquitous Thanks for getting the ball rolling with this!

I forgot (when I transferred the issue over) that the templates here are meant to be generic as they are applied to all the repos that don't have their own templates.

Let's do the generic templates first, then write more specific ones for the stylelint/stylelint repo based on those.

So, let's:

  • store what you've written here
  • strip this template back to match the content of the generic template we have at the moment (as, for example, a lot of the questions are irrelevant if reporting a bug with the website)

I suggest moving the "(e.g. what warnings or errors did you get)?" of the last question into the "description" field.

.github/ISSUE_TEMPLATE/REPORT_A_BUG.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/REPORT_A_BUG.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/REPORT_A_BUG.yml Outdated Show resolved Hide resolved
ybiquitous and others added 3 commits October 29, 2021 02:30
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
@ybiquitous
Copy link
Member Author

@jeddy3 Thanks for the feedback! I've addressed the reviews, so please check again. 😃

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes. Almost there.

I've made 2 suggestions.

GitHub is complaining about:

title must be of type String and cannot be empty. Learn more.
body[1]: description must be of type String and cannot be empty. Learn more.
body[1]: placeholder must be of type String and cannot be empty. Learn more.
body[2]: description must be of type String and cannot be empty. Learn more.
body[2]: placeholder must be of type String and cannot be empty. Learn more.
body[3]: description must be of type String and cannot be empty. Learn more.
body[3]: placeholder must be of type String and cannot be empty. Learn more.
body[4]: description must be of type String and cannot be empty. Learn more.
body[4]: placeholder must be of type String and cannot be empty. Learn more.
Body must contain at least one non-markdown field. Learn more.

For the title and body[x] I think we simply need to remove the fields rather than have an empty string as they're optional.

For Body, I think we need to move the indentation in a level before it:

body
- type markdown
..

.github/ISSUE_TEMPLATE/REPORT_A_BUG.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/REPORT_A_BUG.yml Outdated Show resolved Hide resolved
@jeddy3
Copy link
Member

jeddy3 commented Oct 28, 2021

Incidentally, is there any way to preview what this will look like?

@ybiquitous
Copy link
Member Author

Thanks, I'll fix them soon!

GitHub is complaining about:

BTW, what checker are you using?

@ybiquitous
Copy link
Member Author

Incidentally, is there any way to preview what this will look like?

I'll create a test repo. 💪🏼

ybiquitous and others added 2 commits October 29, 2021 03:08
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
@jeddy3
Copy link
Member

jeddy3 commented Oct 28, 2021

BTW, what checker are you using?

Just clicking on view file. It shows the warnings on the next page.

Screenshot 2021-10-28 at 19 08 57

@jeddy3
Copy link
Member

jeddy3 commented Oct 28, 2021

I'll create a test repo. 💪🏼

Oh, no need now. It renders now that the validation warnings are fixed.

@ybiquitous
Copy link
Member Author

Oh, no need now. It renders now that the validation warnings are fixed.

Ah, I've created it. 😅
Try https://github.com/ybiquitous/issue-form-example/issues/new/choose if OK.

I'll remove the test repo after the merge.

@ybiquitous
Copy link
Member Author

@jeddy3 All done!

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last request, otherwise LGTM.


As an aside, it's a shame the rendered form is littered with red asterisks. The UK GOV has good research that those aren't great for user experience, and recommends putting "(optional)" after optional fields instead.

It's a minor compliant as the form is significantly better than our current approach.

.github/ISSUE_TEMPLATE/REPORT_A_BUG.yml Outdated Show resolved Hide resolved
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
@ybiquitous
Copy link
Member Author

Now it's pretty simple. Nice. 👍🏼

https://github.com/ybiquitous/issue-form-example/issues/new?assignees=&labels=&template=REPORT_A_BUG.yml

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@ybiquitous
Copy link
Member Author

Thanks for the review! Feel free to merge! 😊

@jeddy3 jeddy3 merged commit a026671 into master Oct 28, 2021
@jeddy3 jeddy3 deleted the new-bug-report-form branch October 28, 2021 18:29
@ybiquitous
Copy link
Member Author

Next step, I'll create the remaining issue forms. 💪🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants