Update to PostCSS@6

[ntwb]

Updates postcss to the latest 6.x version

Supersedes #2548

[ntwb]

Related PRs, I didn't create new PRs for these as they'll need rebasing once this PR is merged, theoretically they all also require and are dependant on this PR also:

• #2555 postcss-scss
• #2553 sugarss
• #2554 postcss-safe-parser
• #2588 autoprefixer

[jeddy3]

I suggest we just update everything related to postcss@6 in this PR for the sake of simplicity.

[hudochenkov]

I think we could delay this until 8.0. This way we won't have much merge conflicts with master. And by that time other dependencies (and PostCSS) fix their bugs, if any :)

[jeddy3]

I think we could delay this until 8.0

Yep, it's pointing to the v8 branch. We can merge master into v8 before working on this PR.

[jeddy3]

I've rebased this on v8.

[jeddy3]

Summary:

Test Suites: 5 failed, 267 passed, 272 total
Tests:       26 failed, 13042 passed, 13068 total
Snapshots:   7 passed, 7 total
Time:        108.692s
Ran all test suites.

26 failed, 13042 passed is a pretty decent ratio :)

The failing suites are:

• lib/rules/no-extra-semicolons/__tests__/index.js
• lib/rules/block-closing-brace-newline-after/__tests__/index.js
• lib/__tests__/ignoreDisables.test.js
• lib/__tests__/defaultSeverity.test.js
• lib/__tests__/postcssPlugin.test.js

I suggest we tackle them individually as PRs into this branch v8-postcss-six. Drop a note in here if you've about to start on one.

I'm going to give lib/rules/block-closing-brace-newline-after/__tests__/index.js a go now.

[jeddy3]

Going to look at lib/__tests__/postcssPlugin.test.js

[jeddy3]

Going to look at lib/__tests__/defaultSeverity.test.js and commit directly here.

[alexander-akait]

seems npm@5 output incorrect node_modules where postcss v5 on top

[alexander-akait]

Need resolve too davidtheclark/postcss-resolve-nested-selector#3

[alexander-akait]

@ai seems bug in postcss
Input:

:root { --foo: { color: red };; }

Output for --foo:

Rule {
      raws: 
       { before: ' ',
         between: ' ',
         semicolon: false,
         after: ' ',
         ownSemicolon: ';' },
      type: 'rule',
      nodes: 
       [ Declaration {
           raws: [Object],
           type: 'decl',
           parent: [Circular],
           source: [Object],
           prop: 'color',
           value: 'red' } ],
      parent: 
       Rule {
         raws: { before: '', between: ' ', semicolon: false, after: ' ' },
         type: 'rule',
         nodes: [ [Circular] ],
         parent: 
          Root {
            raws: [Object],
            type: 'root',
            nodes: [Object],
            source: [Object],
            lastEach: 4,
            indexes: [Object] },
         source: { start: [Object], input: [Object], end: [Object] },
         selector: ':root',
         lastEach: 4,
         indexes: { '4': 0 } },
      source: 
       { start: { line: 1, column: 9 },
         input: 
          Input {
            css: ':root { --foo: { color: red };; }',
            id: '<input css 1>' },
         end: { line: 1, column: 29 } },
      selector: '--foo:',
      lastEach: 3,
      indexes: {} }

No information about extra semicolon, stringify this node output: --foo: { color: red }; (without extra semicolon). Also no information in docs about ownSemicolon: ';'

[ai]

@evilebottnawi fixed postcss/postcss@dde2808

[alexander-akait]

@ai in my example we lose extra semicolon in Rule, no information about this 😞

[ai]

@evilebottnawi what is expected output?

[alexander-akait]

@ai To tell the truth I do not know, but try :root { --foo: { color: red };; } parse and stringify (output :root { --foo: { color: red }; } without extra semicolon)

[ai]

Yeap, it is a bug. Please create issue, I will try to fix it tomorrow.

[alexander-akait]

wip

[alexander-akait]

@jeddy3 seems bug in npm@5 😞

[alexander-akait]

restarting and clearing caches do not solve problem 😞 maybe before npm@5 become stable add allow failure to travis

[jeddy3]

Green after purging all the caches.

@evilebottnawi Thanks for following up on the no-extra-semicolon rule. Thanks @ai for addressing the custom property set semicolon so quickly!

This looks good to me.

[hudochenkov]

Good job, everyone!

[jeddy3]

8.0.0 changelog:

• Changed: compatibility with postcss from @5 to @6 (#2561).