Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update postcss-less to the latest version 🚀 #2637

Closed
wants to merge 1 commit into from

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Jun 14, 2017

Version 1.0.2 of postcss-less just got published.

Dependency postcss-less
Current Version 0.14.0
Type dependency

The version 1.0.2 is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of postcss-less.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.


Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

@alexander-akait
Copy link
Member

Most of error contain TypeError: this[node.type] is not a function

@jwilsson
Copy link
Member

Hi!
Since I ran into the same issue when updating to postcss-less 1.0.0 on another project I thought I'd save someone some debugging time in the future.

What's needed to fix the TypeError: this[node.type] is not a function errors is a custom stringifier because postcss-less won't emit @import nodes as AtRule but Import anymore. This is because they can contain import directives and it was decided they're better off as their own node type.

Please feel free to ping me when you're ready to update postcss-less and I'll see what I can do to help out (I saw there's some other postcss 6 work and a v8 branch and wasn't sure how you wish to handle it).

@jeddy3
Copy link
Member

jeddy3 commented Jun 28, 2017

Since I ran into the same issue when updating to postcss-less 1.0.0 on another project I thought I'd save someone some debugging time in the future.

Thank you!

Please feel free to ping me when you're ready to update postcss-less and I'll see what I can do to help out (I saw there's some other postcss 6 work and a v8 branch and wasn't sure how you wish to handle it).

That's very kind, thanks. Any help with this issue would be greatly appreciated! It looks like postcss-less uses postcss@5, so we needn't tie updating postcss-less into the postcss@6 update work. The v8 branch is going to be the next release. As such, if you like, feel free to branch off v8 and have a go at updating postcss-less there. We can then close this greenkeeper PR as a duplicate.

@jwilsson
Copy link
Member

@jeddy3 Cool, I'll see what I can do!

@alexander-akait
Copy link
Member

@jeddy3 should we fix problems with less in master branch or we will do this in v8?

@jeddy3
Copy link
Member

jeddy3 commented Jun 29, 2017

v8, as it should be the next release unless there's an urgent patch for 7.x is required.

@alexander-akait
Copy link
Member

@shellscape stylelint started migration on postcss@6, can your release new version postcss-less with support postcss@6?

@jeddy3
Copy link
Member

jeddy3 commented Jul 1, 2017

Dupe of #2702

@jeddy3 jeddy3 closed this Jul 1, 2017
@jeddy3 jeddy3 deleted the greenkeeper/postcss-less-1.0.2 branch July 1, 2017 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants