Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ConfigurationError type #5696

Merged
merged 3 commits into from
Nov 8, 2021
Merged

Add ConfigurationError type #5696

merged 3 commits into from
Nov 8, 2021

Conversation

adalinesimonian
Copy link
Member

Adds the ConfigurationError type. Currently, we define this type downstream since it isn't defined in Stylelint, but it really belongs here.

ybiquitous
ybiquitous approved these changes Nov 6, 2021
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍🏼

lib/utils/configurationError.js Show resolved Hide resolved
jeddy3
jeddy3 approved these changes Nov 8, 2021
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

Can you resolve the conflict please, then I'll merge?

(We typically don't include adding CHANGELOG entries in the pull request themselves (to avoid these conflicts). It's normally done afterwards in a commit by whoever merges.)

@jeddy3
Copy link
Member

jeddy3 commented Nov 8, 2021

Nevermind, did it in GitHub... 😄 will merge on green.

@jeddy3 jeddy3 changed the title feat: Add ConfigurationError type Add ConfigurationError type Nov 8, 2021
@jeddy3 jeddy3 merged commit fe4efc2 into main Nov 8, 2021
@jeddy3 jeddy3 deleted the type-configuration-error branch November 8, 2021 17:54
@adalinesimonian
Copy link
Member Author

Nevermind, did it in GitHub... 😄 will merge on green.

Thanks!

(We typically don't include adding CHANGELOG entries in the pull request themselves (to avoid these conflicts). It's normally done afterwards in a commit by whoever merges.)

Noted!

@sync-by-unito sync-by-unito bot mentioned this pull request Dec 1, 2021
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Jan 1, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Jan 27, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Mar 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybiquitous ybiquitous ybiquitous approved these changes

@jeddy3 jeddy3 jeddy3 approved these changes

@hudochenkov hudochenkov Awaiting requested review from hudochenkov

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adalinesimonian @jeddy3 @ybiquitous