Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add problem code actions #322

Merged
merged 9 commits into from
Nov 14, 2021
Merged

feat: Add problem code actions #322

merged 9 commits into from
Nov 14, 2021

Conversation

adalinesimonian
Copy link
Member

@adalinesimonian adalinesimonian commented Nov 13, 2021

Resolves #39, Resolves #185

  • Adds:
    • Code action to disable a rule for a specific line
    • Code action to disable a rule for an entire file
    • Code action to show documentation for a rule
  • Fixes a bug where configuration would not update when edited.
  • Makes it so that if the extension fails to start the language server or to send events, the errors are displayed to the user instead of silently failing.
  • Adds the DidResetConfiguration notification to the server and the corresponding API event to the extension to allow end-to-end tests to know when the configuration has been updated in the extension after editing .vscode/settings.json in a test.

Resolves #39, Resolves #185

Also fixes a bug where configuration would not update when edited
@adalinesimonian
Copy link
Member Author

Unit tests won't pass just yet, changes are required. End-to-end tests pass, but no e2e test has been added just yet for this new functionality.

@adalinesimonian adalinesimonian marked this pull request as ready for review November 13, 2021 05:18
@adalinesimonian adalinesimonian marked this pull request as draft November 13, 2021 05:18
@adalinesimonian adalinesimonian marked this pull request as ready for review November 14, 2021 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rule documentation code action for reported problems Add code action for fixing / disabling issues
1 participant