Fixes #444 - Allow unsuppressed comments in imports to be compiled #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes stylus#444 Since imports are parsed as Block nodes and Block nodes previously only compiled comments when properties were present, imported comments were being lost. This fix adds comment compilation for Block nodes without properties as well, but only if the Block does not have scope (as is the case with an import). In order to prevent comments from existing plugins and libraries (like Nib) from being compiled, suppressed comments (without '/*!') are ignored.
tj
added a commit
that referenced
this pull request
Jan 4, 2013
Fixes #444 - Allow unsuppressed comments in imports to be compiled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #444, imported comments are being ignored. This seems to be because imports are parsed as Block nodes, which have previously only compiled comments when properties were present. This fix adds comment compilation for Block nodes without properties as well, but only if the Block does not have scope (as is the case with an import). In order to prevent comments from existing plugins and libraries (like Nib) from being compiled, suppressed comments (without '!') are ignored.
Not sure if this is the best way to handle the problem, but it's fairly simple and seems to work well for me. I played with trying to use Root nodes for imports but ran into a lot of problems there. That said, I'd be happy to rework if there's a better way to solve this.