Add "dangerously get member" to SDKs and SAML Update by URL and Doc #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logan-stytch
approved these changes
Nov 15, 2023
Comment on lines
50
to
52
| type DangerouslyGetParams struct { | ||
| MemberID string `json:"member_id,omitempty"` | ||
| } |
There was a problem hiding this comment.
Can we add some docs for this method? It's okay if we don't do it in this PR, but make a task for it to track.
| @@ -22,40 +22,10 @@ type ResetParams struct { | |||
| // SessionToken: A secret token for a given Stytch Session. | |||
| SessionToken string `json:"session_token,omitempty"` | |||
| // SessionJWT: The JSON Web Token (JWT) for a given Stytch Session. | |||
| SessionJWT string `json:"session_jwt,omitempty"` | |||
There was a problem hiding this comment.
Hmm, this looks wrong. We lost a bunch of docs
| @@ -69,34 +39,18 @@ type ResetResponse struct { | |||
| // Member: The [Member object](https://stytch.com/docs/b2b/api/member-object) | |||
| Member organizations.Member `json:"member,omitempty"` | |||
| // Organization: The [Organization object](https://stytch.com/docs/b2b/api/organization-object). | |||
| Organization organizations.Organization `json:"organization,omitempty"` | |||
There was a problem hiding this comment.
Same here, a bunch of missing docs
logan-stytch
approved these changes
Nov 15, 2023
vincent-stytch
changed the title
vincent-stytch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "dangerously get member" to SDKs
SAML Update by URL and Doc