Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in green gauss gradient computations for periodic boundaries #496

Merged
merged 2 commits into from
Jan 13, 2018

Conversation

talbring
Copy link
Member

@talbring talbring commented Jan 11, 2018

This removes the erroneous correction that is being done on periodic boundaries in the GG gradient computation.

Copy link
Member

@economon economon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@economon economon merged commit 68991cd into develop Jan 13, 2018
@economon economon deleted the fix_green_gauss_periodic branch January 13, 2018 09:09
CatarinaGarbacz pushed a commit that referenced this pull request Aug 26, 2019
Fixed bug in green gauss gradient computations for periodic boundaries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants