Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SharedLinkProvider cleanup #308

Merged
merged 1 commit into from
May 15, 2019

Conversation

henryptung
Copy link
Contributor

@henryptung henryptung commented Mar 31, 2019

  • Remove SharedUrl paste-in class, keep necessary bits
  • Remove ownCloud-specific handler (can mangle non-ownCloud links too)
  • Push objects to storage one at a time
  • Do not attach objects to this before storing (avoids vue.js
    contamination)

Fixes #307

- Remove SharedUrl paste-in class, keep necessary bits
- Remove ownCloud-specific handler (can mangle non-ownCloud links too)
- Push objects to storage one at a time
- Do not attach objects to this before storing (avoids vue.js
contamination)
@henryptung
Copy link
Contributor Author

henryptung commented Mar 31, 2019

Important note: I didn't port over the ownCloud link handling because it seems prone to mangling legitimate non-ownCloud links (i.e. any alphanumeric folder with exactly 15 chars will get a /download stuck on the end). I can add it back if desired, but just FYI.

Also, for the file-path check, the old check looked like it only forbade URLs with no path at all (e.g. http://example.com and allowed URLs with any path at all, e.g. http://example.com/. That didn't seem very meaningful (why refuse the former if you're going to accept the latter anyway?), so I went out on a limb and assumed it wanted to block "directory-like" urls (i.e. ones ending in /) - if that's mistaken, I can implement whatever check is desired here (or remove the check altogether).

@mishley
Copy link

mishley commented Apr 1, 2019

Just wanted to confirm that I'm seeing this same behaviour. I use a permalink via Nextcloud, and it's currently acting just as @henryptung described in his bug report.

@henryptung
Copy link
Contributor Author

@subdavis Any thoughts or concerns with the changes?

Copy link
Owner

@subdavis subdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henryptung thanks for your work here. Code looks great. Agree with your changes.

I'm going to merge now, test, and push a batch of changes to the store eventuallt.

@subdavis subdavis merged commit 9c9ed82 into subdavis:develop May 15, 2019
@jfcardinal
Copy link

I'm going to merge now, test, and push a batch of changes to the store eventuallt.

When is that going to happen? I just found out that Shared Links don't work in Firefox after using them in Chrome. Firefox is my preferred browser, and I was using an old version--with legacy extensions--until now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firefox: Shared URL provider doesn't work
4 participants