feat(dialect-tauri): improve execute logic

Author: subframe7536

packages/dialect-tauri/README.md

@@ -31,4 +31,9 @@ export interface TauriSqlDialectConfig<T extends 'sqlite' | 'mysql' | 'postgres'
   type: T
   onCreateConnection?: (connection: DatabaseConnection) => Promisable<void>
 }
-```
+```
+
+### known issue
+
+- no RETURNING support
+- only return rows when executing raw sql

packages/dialect-tauri/src/driver.ts

@@ -78,28 +78,23 @@ class TauriSqlConnection implements DatabaseConnection {
     this.db = db
   }
 
-  async exec(sql: string, param?: readonly unknown[]) {
-    const { lastInsertId, rowsAffected } = await this.db.execute(sql, param as any)
-    return {
-      numAffectedRows: BigInt(rowsAffected),
-      insertId: BigInt(lastInsertId),
-    }
-  }
-
   streamQuery<R>(): AsyncIterableIterator<QueryResult<R>> {
     throw new Error('Tauri sql plugin doesn\'t support streaming')
   }
 
-  async executeQuery<R>(compiledQuery: CompiledQuery<unknown>): Promise<QueryResult<R>> {
-    const { parameters, sql, query } = compiledQuery
-    return Promise.resolve((query.kind === 'SelectQueryNode' || query.kind === 'RawNode')
-      ? {
-          rows: await this.db.select(sql, parameters as any),
-        }
-      : {
+  async executeQuery<R>({ parameters, query, sql }: CompiledQuery<unknown>): Promise<QueryResult<R>> {
+    switch (query.kind) {
+      case 'SelectQueryNode':
+      case 'RawNode':
+        return { rows: await this.db.select<any>(sql, parameters) }
+      default: {
+        const { lastInsertId, rowsAffected } = await this.db.execute(sql, parameters)
+        return {
           rows: [],
-          ...await this.exec(sql, parameters),
-        },
-    )
+          insertId: BigInt(lastInsertId),
+          numAffectedRows: BigInt(rowsAffected),
+        }
+      }
+    }
   }
 }

packages/dialect-tauri/src/index.ts

@@ -42,7 +42,8 @@ export class TauriSqlDialect<T extends 'sqlite' | 'mysql' | 'postgres'> {
    * using [official sql plugin](https://github.com/tauri-apps/plugins-workspace/tree/dev/plugins/sql),
    * support MySQL, PostgreSQL and SQLite
    *
-   * currently no support for bigint
+   * - no RETURNING support
+   * - only return rows when executing raw sql
    */
   constructor(config: TauriSqlDialectConfig<T>) {
     this.#config = {

packages/dialect-tauri/src/type.ts

@@ -2,8 +2,8 @@
  * https://github.com/tauri-apps/plugins-workspace/blob/dev/plugins/sql/guest-js/index.ts
  */
 export interface TauriSqlDB {
-  execute(query: string, bindValues?: unknown[]): Promise<QueryResult>
-  select<T>(query: string, bindValues?: unknown[]): Promise<T>
+  execute(query: string, bindValues?: readonly unknown[]): Promise<QueryResult>
+  select<T>(query: string, bindValues?: readonly unknown[]): Promise<T>
   close: () => Promise<boolean>
 }
 export interface QueryResult {