Skip to content

Commit e5f3d98

Browse files
committed
feat(builder, utils): rename precompile methods
1 parent 04954c8 commit e5f3d98

File tree

4 files changed

+15
-15
lines changed

4 files changed

+15
-15
lines changed

packages/sqlite-builder/src/builder.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -269,15 +269,15 @@ export class SqliteBuilder<DB extends Record<string, any>> {
269269
* @param queryBuilder param builder
270270
* @returns function to {@link CompileFn compile}
271271
*/
272-
query: <O>(
272+
build: <O>(
273273
queryBuilder: (db: Kysely<DB>, param: <K extends keyof T>(name: K) => T[K]) => Compilable<O>,
274274
) => {
275275
let compiled: CompiledQuery<Compilable<O>> | null
276276
const dispose = () => compiled = null
277277
return {
278278
[Symbol.dispose]: dispose,
279279
dispose,
280-
generate: (param: T) => {
280+
compile: (param: T) => {
281281
if (!compiled) {
282282
const { parameters, sql, query } = queryBuilder(this.kysely, getPrecompileParam).compile()
283283
compiled = {

packages/sqlite-utils/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,10 @@ function createPrecompile<T extends Record<string, any>>(options?: PrecompileOpt
3737
* @param queryBuilder param builder
3838
* @returns function to {@link CompileFn compile}
3939
*/
40-
query: <O>(queryBuilder: (param: <K extends keyof T>(name: K) => T[K]) => Compilable<O>) => {
40+
build: <O>(queryBuilder: (param: <K extends keyof T>(name: K) => T[K]) => Compilable<O>) => {
4141
[Symbol.dispose]: () => null
4242
dispose: () => null
43-
generate: (param: T) => CompiledQuery<QueryBuilderOutput<O>>
43+
compile: (param: T) => CompiledQuery<QueryBuilderOutput<O>>
4444
}
4545
}
4646
// old util, reference from https://github.com/jtlapp/kysely-params

packages/sqlite-utils/src/precompile.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ export function precompileQuery<O>(
100100
* .query((param) =>
101101
* db.selectFrom('test').selectAll().where('name', '=', param('name')),
102102
* )
103-
* const compileResult = select.generate({ name: 'test' })
103+
* const compileResult = select.compile({ name: 'test' })
104104
* // {
105105
* // sql: 'select * from "test" where "name" = ?',
106106
* // parameters: ['test'],
@@ -110,7 +110,7 @@ export function precompileQuery<O>(
110110
*
111111
* // or auto disposed by using
112112
* using selectWithUsing = createPrecompile<{ name: string }>(options)
113-
* .query((param) =>
113+
* .build((param) =>
114114
* db.selectFrom('test').selectAll().where('name', '=', param('name')),
115115
* )
116116
*/
@@ -125,15 +125,15 @@ export function createPrecompile<T extends Record<string, any>>(options: Precomp
125125
* @param queryBuilder param builder
126126
* @returns function to {@link CompileFn compile}
127127
*/
128-
query: <O>(
128+
build: <O>(
129129
queryBuilder: (param: <K extends keyof T>(name: K) => T[K]) => Compilable<O>,
130130
) => {
131131
let compiled: CompiledQuery<Compilable<O>> | null
132132
const dispose = () => compiled = null
133133
return {
134134
[Symbol.dispose]: dispose,
135135
dispose,
136-
generate: (param: T) => {
136+
compile: (param: T) => {
137137
if (!compiled) {
138138
const { parameters, sql, query } = queryBuilder(getPrecompileParam).compile()
139139
compiled = {

test/builder.test.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -126,36 +126,36 @@ describe('test builder', async () => {
126126
})
127127
it('should precompile', async () => {
128128
const select = db.precompile<{ person: { name: string }, test?: 'asd' }>()
129-
.query((d, param) =>
129+
.build((d, param) =>
130130
d.selectFrom('test').selectAll().where('person', '=', param('person')),
131131
)
132132
const insert = db.precompile<{ gender: boolean }>()
133-
.query((db, param) =>
133+
.build((db, param) =>
134134
db.insertInto('test').values({ gender: param('gender') }),
135135
)
136136
const update = db.precompile<{ gender: boolean }>()
137-
.query((db, param) =>
137+
.build((db, param) =>
138138
db.updateTable('test').set({ gender: param('gender') }).where('id', '=', 1),
139139
)
140140

141141
const start = performance.now()
142142

143-
const { parameters, sql } = select.generate({ person: { name: '1' } })
143+
const { parameters, sql } = select.compile({ person: { name: '1' } })
144144
expect(sql).toBe('select * from "test" where "person" = ?')
145145
expect(parameters).toStrictEqual(['{"name":"1"}'])
146146

147147
const start2 = performance.now()
148148
console.log('no compiled:', `${(start2 - start).toFixed(2)}ms`)
149149

150-
const { parameters: p1, sql: s1 } = select.generate({ person: { name: 'test' } })
150+
const { parameters: p1, sql: s1 } = select.compile({ person: { name: 'test' } })
151151
expect(s1).toBe('select * from "test" where "person" = ?')
152152
expect(p1).toStrictEqual(['{"name":"test"}'])
153153

154154
console.log(' compiled:', `${(performance.now() - start2).toFixed(2)}ms`)
155155

156-
const result = await db.execute(insert.generate({ gender: true }))
156+
const result = await db.execute(insert.compile({ gender: true }))
157157
expect(result.rows).toStrictEqual([])
158-
const result2 = await db.execute(update.generate({ gender: false }))
158+
const result2 = await db.execute(update.compile({ gender: false }))
159159
expect(result2.rows).toStrictEqual([])
160160
})
161161
})

0 commit comments

Comments
 (0)