fix(dialect-wasm): improve types

Author: subframe7536

packages/dialect-wasm/src/crsqlite-dialect/driver.ts

@@ -15,9 +15,8 @@ export class CrSqliteDriver extends BaseDriver {
       ? await this.config.database()
       : this.config.database
     this.connection = new CrSqliteConnection(this.db)
-    if (this.config.onCreateConnection) {
-      await this.config.onCreateConnection(this.connection)
-    }
+
+    await this.config.onCreateConnection?.(this.connection)
   }
 
   async destroy(): Promise<void> {

packages/dialect-wasm/src/crsqlite-dialect/index.ts

@@ -1,11 +1,12 @@
 import type { DatabaseConnection, Driver } from 'kysely'
 import { BaseDialect } from '../baseDialect'
+import type { Promisable } from '../util'
 import { CrSqliteDriver } from './driver'
 import type { CrSqliteDB } from './type'
 
 export interface CrSqliteDialectConfig {
-  database: CrSqliteDB | (() => Promise<CrSqliteDB>)
-  onCreateConnection?: (connection: DatabaseConnection) => Promise<void>
+  database: CrSqliteDB | (() => Promisable<CrSqliteDB>)
+  onCreateConnection?: (connection: DatabaseConnection) => Promisable<void>
 }
 export class CrSqliteDialect extends BaseDialect {
   #config: CrSqliteDialectConfig

packages/dialect-wasm/src/node-wasm-dialect/driver.ts

@@ -15,9 +15,8 @@ export class NodeWasmDriver extends BaseDriver {
       ? await this.#config.database()
       : this.#config.database
     this.connection = new NodeWasmConnection(this.#db)
-    if (this.#config.onCreateConnection) {
-      await this.#config.onCreateConnection(this.connection)
-    }
+
+    await this.#config.onCreateConnection?.(this.connection)
   }
 
   async destroy(): Promise<void> {

packages/dialect-wasm/src/node-wasm-dialect/index.ts

@@ -1,11 +1,12 @@
 import type { DatabaseConnection, Driver } from 'kysely'
 import { BaseDialect } from '../baseDialect'
+import type { Promisable } from '../util'
 import type { NodeWasmDataBase } from './type'
 import { NodeWasmDriver } from './driver'
 
 export interface NodeWasmDialectConfig {
-  database: NodeWasmDataBase | (() => Promise<NodeWasmDataBase>)
-  onCreateConnection?: (connection: DatabaseConnection) => Promise<void>
+  database: NodeWasmDataBase | (() => Promisable<NodeWasmDataBase>)
+  onCreateConnection?: (connection: DatabaseConnection) => Promisable<void>
 }
 
 export class NodeWasmDialect extends BaseDialect {

packages/dialect-wasm/src/official-wasm-dialect/driver.ts

@@ -15,9 +15,8 @@ export class OfficialWasmDriver extends BaseDriver {
       ? await this.config.database()
       : this.config.database
     this.connection = new OfficailSqliteWasmConnection(this.db)
-    if (this.config.onCreateConnection) {
-      await this.config.onCreateConnection(this.connection)
-    }
+
+    await this.config.onCreateConnection?.(this.connection)
   }
 
   async destroy(): Promise<void> {

packages/dialect-wasm/src/official-wasm-dialect/index.ts

@@ -1,11 +1,12 @@
 import type { DatabaseConnection } from 'kysely'
 import { BaseDialect } from '../baseDialect'
+import type { Promisable } from '../util'
 import { OfficialWasmDriver } from './driver'
 import type { OfficialWasmDB } from './type'
 
 export interface OfficialWasmDialectConfig {
-  database: OfficialWasmDB | (() => Promise<OfficialWasmDB>)
-  onCreateConnection?: (connection: DatabaseConnection) => Promise<void>
+  database: OfficialWasmDB | (() => Promisable<OfficialWasmDB>)
+  onCreateConnection?: (connection: DatabaseConnection) => Promisable<void>
 }
 
 export class OfficialWasmDialect extends BaseDialect {

packages/dialect-wasm/src/sqljs-dialect/driver.ts

@@ -85,9 +85,7 @@ export class SqlJsDriver extends BaseDriver {
       this.config.onWrite?.delay,
     )
 
-    if (this.config.onCreateConnection) {
-      await this.config.onCreateConnection(this.connection)
-    }
+    await this.config.onCreateConnection?.(this.connection)
   }
 
   async beginTransaction(connection: SqlJsConnection): Promise<void> {

packages/dialect-wasm/src/sqljs-dialect/index.ts

@@ -1,10 +1,11 @@
 import type { DatabaseConnection, Driver } from 'kysely'
 import { BaseDialect } from '../baseDialect'
+import type { Promisable } from '../util'
 import { SqlJsDriver } from './driver'
 import type { SqlJSDB } from './type'
 
 export interface SqlJsDialectConfig {
-  database: SqlJSDB | (() => Promise<SqlJSDB>)
+  database: SqlJSDB | (() => Promisable<SqlJSDB>)
   onWrite?: {
     func: (buffer: Uint8Array) => void
     /**
@@ -20,7 +21,7 @@ export interface SqlJsDialectConfig {
      */
     maxCalls?: number
   }
-  onCreateConnection?: (connection: DatabaseConnection) => Promise<void>
+  onCreateConnection?: (connection: DatabaseConnection) => Promisable<void>
 }
 export class SqlJsDialect extends BaseDialect {
   readonly #config: SqlJsDialectConfig

packages/dialect-wasm/src/util.ts

@@ -15,8 +15,10 @@ import { CompiledQuery } from 'kysely'
  */
 export async function optimzePragma(conn: DatabaseConnection, cacheSize = 4096, pageSize = 32 * 1024): Promise<void> {
   await conn.executeQuery(CompiledQuery.raw(`PRAGMA cache_size = ${cacheSize};`))
-  await conn.executeQuery(CompiledQuery.raw('PRAGMA journal_mode = MEMORY;'))
-  await conn.executeQuery(CompiledQuery.raw('PRAGMA locking_mode = MEMORY;'))
-  await conn.executeQuery(CompiledQuery.raw('PRAGMA temp_store = 2;'))
+  await conn.executeQuery(CompiledQuery.raw('PRAGMA journal_mode = WAL;'))
+  await conn.executeQuery(CompiledQuery.raw('PRAGMA temp_store = MEMORY;'))
   await conn.executeQuery(CompiledQuery.raw(`PRAGMA page_size = ${pageSize};`))
+  await conn.executeQuery(CompiledQuery.raw('PRAGMA synchronous = NORMAL;'))
 }
+
+export type Promisable<T> = T | Promise<T>

packages/dialect-wasm/src/wasqlite-dialect/driver.ts

@@ -15,9 +15,8 @@ export class WaSqliteDriver extends BaseDriver {
       ? await this.config.database()
       : this.config.database
     this.connection = new WaSqliteConnection(this.db)
-    if (this.config.onCreateConnection) {
-      await this.config.onCreateConnection(this.connection)
-    }
+
+    await this.config.onCreateConnection?.(this.connection)
   }
 
   async destroy(): Promise<void> {