Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HTML] Improve completions for empty elements #101

Merged
merged 1 commit into from
Feb 9, 2016
Merged

[HTML] Improve completions for empty elements #101

merged 1 commit into from
Feb 9, 2016

Conversation

philipbordallo
Copy link
Contributor

[HTML] Improve completions for empty elements

Some empty elements are completing with a closing element.

For example area is currently completing to:

<area></area>

When it should be completing to:

<area>

This will fix completions for: <area>, <col>, <base>, <meta>, <hr>, <br>, <wbr>, <input>.

meta's completion will render as:

<meta charset="utf-8">
      ^-------------^
       Selected Text

Which means a tab keypress will jump to after the >, completing the example or a delete keypress will remove the example and allow for another attribute input. This way it's easier to input something other than just the default.

@kleinfreund
Copy link
Contributor

👍

@wbond
Copy link
Member

wbond commented Feb 9, 2016

Like it, thanks!

wbond added a commit that referenced this pull request Feb 9, 2016
[HTML] Improve completions for empty elements
@wbond wbond merged commit b4e8888 into sublimehq:master Feb 9, 2016
@philipbordallo philipbordallo deleted the html-empty-completions branch February 10, 2016 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants