[CSS] Fix <0x01> in completion labels #2454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like python requires a raw string to perform proper regexp
replacement. The intention here is to replace `${1:param}` by `param` so
the completion list displays named function arguments.
FichteFoll
approved these changes
Aug 18, 2020
There was a problem hiding this comment.
Not sure why this behavior should have changed in 3.8. It does't seem to from my tests, but this is the correct solution regardless.
~ $ python3.8
Python 3.8.5 (default, Jul 27 2020, 08:42:51)
[GCC 10.1.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> "\1"
'\x01'
>>>
~ Ξ python3.3
Python 3.3.7 (default, Oct 5 2017, 02:25:52)
[GCC 7.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> "\1"
'\x01'
>>> import re
>>> re.sub(r".", "\1", "1235")
'\x01\x01\x01\x01'
>>>
|
Most likely it is just that we draw these now? |
charlievieth
pushed a commit
to charlievieth/Packages
that referenced
this pull request
Aug 25, 2020
Looks like python requires a raw string to perform proper regexp
replacement. The intention here is to replace `${1:param}` by `param` so
the completion list displays named function arguments.
mitranim
pushed a commit
to mitranim/Packages
that referenced
this pull request
Mar 25, 2022
Looks like python requires a raw string to perform proper regexp
replacement. The intention here is to replace `${1:param}` by `param` so
the completion list displays named function arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like python 3.8? requires a raw string to perform proper regexp replacement. The intention here is to replace
${1:param}byparamso the completion list displays named function arguments.