[ShellScript] Add support for dash shebang #2819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith-hall
previously approved these changes
May 15, 2021
mohamed-abdelnour
changed the title
rwols
previously approved these changes
May 15, 2021
|
Please fix column position of trailing comment, so all trailing comments are located at the same column. |
|
Thanks |
deathaxe
approved these changes
May 16, 2021
|
You're welcome! |
|
Please note. I've synced this PR with #2760 by adding DASH there, too. It is to avoid it being lost due to merge conflicts etc. |
|
Sounds good. Shall we close this PR, then? |
|
Not neccessarily. It's not yet for sure the other PR will ever be accepted. |
jfcherng
approved these changes
Aug 18, 2021
|
Since the other PR is marked as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a patch to
Bash.sublime-syntaxthat adds support for shebangs explicitly calling for dash, e.g.,#!/usr/bin/env dash. Proposed in sharkdp/bat#1654.I have not modified the Bash syntax test file since the dash shell supports less features than Bash.