[Regular Expressions] fix #332 and [Clojure] fix and add tests

[keith-hall]

fix #332

[keith-hall]

for some reason, pushing a context (using an empty match pattern) directly from the main context seems to cause the first character to not get the correct scope in some situations. The fix is to set the context instead of pushing it.

[wbond]

Hmm, I think we'll want to do this a different way since this could break if this syntax is embedded in another language (like it is with Clojure right now).

I may have to dig in to the ST source and see what is causing the issue.

[keith-hall]

I may have to dig in to the ST source and see what is causing the issue.

that would be perfect ;)

[keith-hall]

I think it is already broken for Clojure because Regular Expressions uses a push in main, and the Clojure syntax just includes the Regular Expressions main context, and there is no with_prototype or anything to pop it off the stack when the closing " character is reached.

Unfortunately, the Clojure syntax doesn't have any tests, or I would have discovered it while developing my changes. (and it also shows how important it is to run all syntax tests before making a PR, not just the tests for the syntax being worked on.)

Confirmed by checking the scopes in this example I modified from the first "hello world clojure" result in google:

(def hello (fn [] #"Hello world"))

so as it stands, I think we will need to make some changes to the Clojure syntax anyway?

[keith-hall]

It looks like we can work around this ST3 bug by changing the Regular Expressions main context to:

main:
  - include: unexpected-quantifier
  - match: ''
    push: base-literal

instead of:

main:
  - match: ''
    push: [base-literal, unexpected-quantifier-pop]

but it doesn't fix the Clojure syntax

[keith-hall]

@wbond, in case it helps you investigate what is causing the bug in the ST source, I have logged an issue with the minimal steps required to repro here: sublimehq/sublime_text#1190

[keith-hall]

I've made a fix for Clojure and added tests :)

I played around a bit in http://www.tryclj.com/ to learn enough Clojure in order to do so ;)

[wbond]

Excellent, thanks for figuring out how to fix this!