[Python] Match unpacking operators #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith-hall
reviewed
Apr 5, 2017
Python/Python.sublime-syntax
Outdated
| - match: \* | ||
| scope: keyword.operator.unpacking.python | ||
| - match: \*\* | ||
| scope: keyword.operator.unpacking.python |
There was a problem hiding this comment.
This pattern will never be matched due to the single * pattern coming before it.
There was a problem hiding this comment.
Currently, 3 or more stars in a row will be scoped as if valid, is that what we want?
There was a problem hiding this comment.
As will stars with spaces between them, which I don't think is valid.
There was a problem hiding this comment.
Nice spot. All fixed (and more).
FichteFoll
force-pushed
the
python_unpacking-operators
branch
from
c6cad62
to
8dc9a04
Compare
FichteFoll
force-pushed
the
python_unpacking-operators
branch
from
8dc9a04
to
53e62dc
Compare
|
Tests passed, thanks! |
deathaxe
pushed a commit
to deathaxe/sublime-packages
that referenced
this pull request
Jun 9, 2019
…erators [Python] Match unpacking operators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #743. Since this is also runs into sublimehq/sublime_text#1190, please confirm locally that the tests pass as I can't.
Fixes #773.