Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New file indication #45

Open
Adarma opened this issue Oct 2, 2018 · 6 comments
Open

New file indication #45

Adarma opened this issue Oct 2, 2018 · 6 comments
Labels
commit detail An issue related to viewing a commit enhancement New feature or request ux A bug or enhancement related to how a user interacts with the app

Comments

@Adarma
Copy link

Adarma commented Oct 2, 2018

Problem description

Clicking a commit shows the files changed by the commit, but there is no way to tell if a file is newly added vs modified.

Preferred solution

Any indication to tell apart, New, Moved, Modified, Deleted, Moved & Modified.

@wbond
Copy link
Member

wbond commented Oct 2, 2018

There are indicators for deleted (trash can icon) and moved (old name -> new name). If a file is moved and modified, the modifications will be shown under the name change header.

Currently there is no indication if a file is new, although if you inspect the diff, you should see it starts at line 0 and has no unmodified lines at the end of the diff. For a modified file where will be up to 3 lines of unmodified content after the last modified line.

@wbond wbond added enhancement New feature or request ux A bug or enhancement related to how a user interacts with the app commit detail An issue related to viewing a commit labels Oct 2, 2018
@Adarma
Copy link
Author

Adarma commented Oct 8, 2018

A new file indicator would be really useful when there are many files listed.
If I do "Collapse all", it would be good to see the new files without having to expand each file.

@jasonycw
Copy link

I think SourceTree support at least 4 status indicator
Modified file, New file, Removed file, Replaced file
image

@dpjohnst
Copy link
Member

Hi all,

Closing as we have all of the mentioned icons in the UI now.

Thanks,
- Dylan

@dpjohnst
Copy link
Member

Hi all,

Re-opening as I realise this was for the commit dialog.
We have a new file icon for past commits, but not in the commit dialog.

Thanks,
- Dylan

@dpjohnst dpjohnst reopened this Sep 22, 2020
@srbs
Copy link

srbs commented Sep 22, 2020

@dpjohnst, it would be nice to get a file_diff_control created like we have for file_diff_control deleted & file_diff_control modified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commit detail An issue related to viewing a commit enhancement New feature or request ux A bug or enhancement related to how a user interacts with the app
Projects
None yet
Development

No branches or pull requests

5 participants