Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ESLint 9 flat config #72

Merged
merged 5 commits into from
Jul 2, 2024
Merged

Support ESLint 9 flat config #72

merged 5 commits into from
Jul 2, 2024

Conversation

predragnikolic
Copy link
Member

closes #68

@predragnikolic
Copy link
Member Author

There are 2 small things: (non of them I see as blockers)

  1. JSON schema for useFlatConfig can be more specific microsoft/vscode-eslint#1885

The default for useFlatConfig is null, but the type in the schema is a boolean.
This point isn't that import, because we do not specify this setting. The server will be able to understand flat configs, as long as someone has ESLint version higher than 8.57.0 (v9.x.x and above). See https://github.com/microsoft/vscode-eslint/pull/1882/files

  1. Should plugins still have eslint.experimental.useFlatConfig in their settings? microsoft/vscode-eslint#1886

While working on this PR, I wanted to remove the eslint.experimental.useFlatConfig

"experimental.useFlatConfig": false,

but doing that will cause the server to throw errors like Cannot read properties of undefined (reading 'useFlatConfig') so I decided to keep the eslint.experimental.useFlatConfig setting for now.

I've opened an issue(question) just to see what their answer is.

sublime-package.json Outdated Show resolved Hide resolved
@predragnikolic predragnikolic merged commit 356d5b3 into main Jul 2, 2024
@predragnikolic predragnikolic deleted the update-server-3.0.10 branch July 2, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support flat config
2 participants