Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The latest LSP-json doesn't work on ST 3. #173

Closed
jfcherng opened this issue Nov 26, 2023 · 2 comments
Closed

The latest LSP-json doesn't work on ST 3. #173

jfcherng opened this issue Nov 26, 2023 · 2 comments

Comments

@jfcherng
Copy link
Contributor

As per report on sublimelsp/LSP-css#46 (comment)

  File "/Applications/Sublime Text 3.app/Contents/MacOS/sublime_plugin.py", line 125, in reload_plugin
    m = importlib.import_module(modulename)
  File "./python3.3/importlib/__init__.py", line 90, in import_module
  File "<frozen importlib._bootstrap>", line 1584, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1565, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1532, in _find_and_load_unlocked
  File "/Applications/Sublime Text 3.app/Contents/MacOS/sublime_plugin.py", line 1199, in load_module
    exec(compile(source, source_path, 'exec'), mod.__dict__)
  File "/Users/juliangarnier/Library/Application Support/Sublime Text 3/Installed Packages/LSP-json.sublime-package/commands.py", line 1, in <module>
ImportError: cannot import name LspTextCommand
@juliangarnier
Copy link

juliangarnier commented Nov 26, 2023

I haven't pinpointed which version of lsp-json breaks ST3 compatibility, but the error mentioned above is similar to these issues:

sublimelsp/LSP-html#45
sublimelsp/LSP-css#46

Where both html / css languages introduced a similar change before breaking ST3 compatibility :

Hope this helps, thanks!

@rchl
Copy link
Member

rchl commented Dec 2, 2023

Addressed. ST3 is now served an older version of LSP-json that doesn't have ST4-specific code.

@rchl rchl closed this as completed Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants