[SKIP CI] add test for cli #100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianhe8x
requested changes
Jan 20, 2021
|
|
||
| jest.mock('ejs', () => { | ||
| const ejsMock = jest.createMockFromModule('ejs') as any; | ||
| ejsMock.renderFile = jest.fn(); |
There was a problem hiding this comment.
This line seems not necessary, it has been done by createMockFromModule
|
|
||
| // 4. Save the rendered schema | ||
| function makeSchema(className: string, data: string): void { | ||
| export async function makeSchema(className: string, data: string): Promise<void> { |
There was a problem hiding this comment.
this abstraction doesn't make sense to me, it is simply wrap of fs.write and once be called once
There was a problem hiding this comment.
merged into renderTemplate
stwiname
added a commit
that referenced
this pull request
Apr 30, 2023
* Move enum under schema (#1527) * need fix query get enum * fix enum query, clean all enums * add logic to handle original enum type * fix check exclude constrain check missing schema and table (#1537) * [SKIP CI] Prerelease * manual prerelease node for node-core update (#1538) * [SKIP CI] Prerelease * resolution for sequelize and prerelease node (#1539) * [SKIP CI] Prerelease * fixed the version of sequelize and prerelease node (#1540) * [SKIP CI] Prerelease * improve force clean with deprecated enum (#1541) * [SKIP CI] Prerelease * Remove exclude constraint (#1543) * deprecate exclude contraint * remove unused * [SKIP CI] Prerelease * [release] 20230306 (#1544) * [release] 20230307 (#1545) * bump yarn.lock, update imports (#1546) * [SKIP CI] Prerelease * [release] 20230307 (#1547) * increase wsProvider timeout (#1550) * increase wsProvider timeout * remove .mmr dir * [SKIP CI] Prerelease * Use performance.now instead of date for profiler. (#1549) * add SmartBatchService and BlockSizeBuffer (#1506) * add SmartBatchService and BlockSizeBuffer * check memory usage before fetching a batch * use v8 heap usage statistics * set block to null after indexing * extend smart batch service to workers * make smart batch size injectible * rebase * bug fixes * code cleanup * assign workers based on free memory * fix liniting * cleanup code * cleanup logs * clear blocksizebuffer inside smartbatchservice --------- Co-authored-by: Scott Twiname <skott.twiname@gmail.com> * Fix build issue with profiler * [SKIP CI] Prerelease * fix abi codegen runtime validation (#1552) * [SKIP CI] Prerelease * [release] 20230309 Cli (#1553) * Fix enum under schema not being escaped (#1555) * [SKIP CI] Prerelease --------- Co-authored-by: Jay Ji <jiqiang90@hotmail.com> Co-authored-by: Ben <89335033+bz888@users.noreply.github.com> Co-authored-by: Scott Twiname <skott.twiname@gmail.com>
stwiname
pushed a commit
that referenced
this pull request
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.