Read initial window size and position from game.project #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, you can merge whenever the Defold fix happens. |
|
I would make this set the view size, not the window size, since the window size also includes window chrome (titlebar, window borders, etc.) |
|
@dapetcu21 I didn't know about this method, I'll take a look. Thank you! |
|
Could somebody test in on windows? (on mac it works perfect) http://d.defold.com/alpha/ |
|
@dapetcu21 I use set_view* instead of set_window* |
|
|
|
I think you forgot to change the name of the props. You only changed them in the README |
|
🙉 fixed! |
|
@AGulev I believe this can be merged now? https://forum.defold.com/t/defold-1-2-188-has-been-released/69477?u=pkeod |
|
@subsoap yes, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pls don't merge before releasing Defold with this fix (PR)