-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hetzner module #303
Hetzner module #303
Conversation
PR Description updated to latest commit (1266f66) |
1266f66
to
22d2622
Compare
22d2622
to
bc7630f
Compare
/review |
PR Review
Code feedback:
✨ Review tool usage guide:Overview: The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
See the review usage page for a comprehensive guide on using this tool. |
@vedhavyas would like to get a review on this please |
@vedhavyas this PR is getting stale and i need to do updates. |
This PR improves on #263 and expands by making a general resources module to launch a network from main branch. It also makes the testing framework and main module reuse the
templates/hetzner
root module.Note for easier reviewing, the commit f0e7f29 doesn't need to be checked since it restores the scripts deleted in #263 to be used by the testing-framework for devnets.
closes #255