Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language editor #660

Merged
merged 5 commits into from Aug 17, 2018
Merged

Language editor #660

merged 5 commits into from Aug 17, 2018

Conversation

Integral
Copy link
Member

This PR introduces a language editor for things like keywords and subject where you can pick a language.

@Integral Integral mentioned this pull request Aug 17, 2018
25 tasks
@codecov-io
Copy link

Codecov Report

Merging #660 into master will decrease coverage by 0.12%.
The diff coverage is 8.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #660      +/-   ##
==========================================
- Coverage    47.3%   47.17%   -0.13%     
==========================================
  Files         277      279       +2     
  Lines        7202     7226      +24     
==========================================
+ Hits         3407     3409       +2     
- Misses       3795     3817      +22
Impacted Files Coverage Δ
src/article/InternalArticleSchema.js 96.82% <ø> (ø) ⬆️
src/article/metadata/TranslatableEntryEditor.js 0% <0%> (ø)
src/article/metadata/LanguageEditor.js 0% <0%> (ø)
src/article/metadata/MetadataPackage.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 681eb6c...10688d8. Read the comment docs.

@michael
Copy link
Member

michael commented Aug 17, 2018

Looking good. Merging this.

@michael michael merged commit 7d80508 into master Aug 17, 2018
@obuchtala obuchtala deleted the language-editor branch August 20, 2018 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants