Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CallbackClient #9

Merged
merged 4 commits into from
Dec 8, 2023
Merged

Implement CallbackClient #9

merged 4 commits into from
Dec 8, 2023

Conversation

DenisCarriere
Copy link
Contributor

@DenisCarriere DenisCarriere commented Dec 8, 2023

Changes

  • Replace createPromiseClient with createCallbackClient
  • Replace emitter.stop() function with CancelFn from Callback Client

Example

const cancel = emitter.start();

// Cancel after 3 seconds
setTimeout(cancel, 3000);

New event emitters

  • close
  • fatalError
type LocalEventTypes = {
  close: [error?: ConnectError];
  fatalError: [error: FatalError];
};

Examples

// End of Stream
emitter.on("close", (error) => {
  if (error) {
    console.error(error);
  }
});

// Fatal error
emitter.on("fatalError", (error) => {
  console.error(error);
});

Copy link

changeset-bot bot commented Dec 8, 2023

⚠️ No Changeset found

Latest commit: 88d40b9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DenisCarriere DenisCarriere merged commit 4046585 into main Dec 8, 2023
2 of 4 checks passed
@DenisCarriere DenisCarriere deleted the feature/callback-client branch December 8, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant