Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7 compatibility #32

Closed
aradi opened this issue Feb 7, 2017 · 4 comments
Closed

PHP 7 compatibility #32

aradi opened this issue Feb 7, 2017 · 4 comments

Comments

@aradi
Copy link

aradi commented Feb 7, 2017

It would be fantastic, if the extension would work when Typo3 is run under PHP 7, as most Linux distributions ship it now as default PHP version. Currently, the version in TER indicates PHP 5 compatibility only.

@ipf
Copy link
Member

ipf commented Feb 7, 2017

Hi, that would indeed be nice. Could you maybe test that and report it?
I am not aware of any 'gems' that could avoid running this in PHP7. The dependency was only added, because PHP7 was not released at that time and so couldn't easily be tested.

@aradi
Copy link
Author

aradi commented Feb 8, 2017

Sure, I'll try it later this week and let you know.

@aradi
Copy link
Author

aradi commented Feb 9, 2017

After removing the constraint on PHP from the package, I could install it without any problems in Typo 3 7.6 with PHP 7. It definitely shows the correct publication lists (filtered and unfiltered). I did not check adding publications so far, but I guess, it would then work as well.

ipf added a commit that referenced this issue Feb 10, 2017
This extends the PHP version requirement to include 7.0 after checking in #32.
Thanks for that, @aradi.
@ipf
Copy link
Member

ipf commented Feb 10, 2017

Thanks for testing and reporting!

@ipf ipf closed this as completed Feb 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants