Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: v1.0.8-testnet #957

Merged
merged 18 commits into from
Jun 20, 2024
Merged

fix: v1.0.8-testnet #957

merged 18 commits into from
Jun 20, 2024

Conversation

ctian1
Copy link
Member

@ctian1 ctian1 commented Jun 18, 2024 •
edited
Loading

  • Change runtime to emit MemoryInit only at the end of execution; this way, when committing/proving in batches, it's only emitted in the last batch
  • Move MemoryProgram and MemoryInit to be in last shard only
  • Change rust / recursion verifiers to handle ^
  • Add num_core_shards to recursion public values, verified 1) to be same across proofs in compress and 2) in assert_complete to == next_shard - 1

tamirhemo
tamirhemo approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@tamirhemo tamirhemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ctian1 ctian1 marked this pull request as ready for review June 19, 2024 20:25
tamirhemo
tamirhemo approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@tamirhemo tamirhemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ctian1 ctian1 merged commit 14eb569 into main Jun 20, 2024
8 of 9 checks passed
@ctian1 ctian1 deleted the chris/v1.0.7-testnet-fix branch June 20, 2024 00:02
@huitseeker huitseeker mentioned this pull request Aug 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamirhemo tamirhemo tamirhemo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctian1 @tamirhemo @jtguibas