Fixes #78
Merged
Fixes #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 1f043bb (Compile .ino and .pde files directly), this dependency was accidentally dropped from these rules. This fixes this by adding it again.
Before, .ino and .pde files would be converted to .cpp files and there is a rule to convert those .cpp files to .s files for make generated_assembly. However, since 1f043bb (Compile .ino and .pde files directly) these intermediate .cpp files are no longer generated, breaking the rule to generate .s files. This fixes this by also generating .s files from .ino and .pde files directly. Closes sudar#76
|
Thanks for the pull request. I just merged it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Sudar,
here's the fix for the assembly I promised. I also noticed a problem with the $(COMMON_DEPS), apparently I accidentally dropped those for .ino and .pde files in an earlier commit.