Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeleteTermsByNameModuleTest fails for the 'not_equal_to' and 'equal_to' datasets #497

Closed
esudalaimadan opened this issue Aug 22, 2018 · 3 comments
Assignees
Milestone

Comments

@esudalaimadan
Copy link
Collaborator

esudalaimadan commented Aug 22, 2018

Blocks #478

There were 4 failures:

  1. BulkWP\BulkDelete\Core\Terms\Modules\DeleteTermsByNameModuleTest::test_that_terms_can_be_deleted_by_name_using_various_filters with data set #0 (array('post', 'post_tag', array('Term A', 'Term B', 'Term C', 'term A')), array('Term A', 'equal_to'), 1, array('Term B', 'Term C', 'term A'))
    Failed asserting that null is not null.

  1. BulkWP\BulkDelete\Core\Terms\Modules\DeleteTermsByNameModuleTest::test_that_terms_can_be_deleted_by_name_using_various_filters with data set Ability to delete posts by custom post type #4 (array('post', 'post_tag', array('Term A', 'Term B', 'Term C', 'term A')), array('Term A', 'not_equal_to'), 3, array('Term A'))
    Failed asserting that 2 matches expected 3.

  1. BulkWP\BulkDelete\Core\Terms\Modules\DeleteTermsByNameModuleTest::test_that_terms_can_be_deleted_by_name_using_various_filters with data set Ability to delete posts based on users #6 (array('post', 'custom_taxonomy', array('Term A', 'Term sample B', 'Term Sample C')), array('Term sample C', 'not_equal_to'), 3, array())
    Failed asserting that 2 matches expected 3.

  1. BulkWP\BulkDelete\Core\Terms\Modules\DeleteTermsByNameModuleTest::test_that_terms_can_be_deleted_by_name_using_various_filters with data set Ability to delete attachments of posts that are getting deleted #7 (array('post', 'custom_taxonomy', array('Term A', 'Term sample B', 'Term Sample C')), array('Term sample', 'not_equal_to'), 0, array('Term A', 'Term sample B', 'Term Sample C'))
    Failed asserting that 3 matches expected 0.
@rajanvijayan
Copy link
Contributor

  1. We could not insert terms with the same name (It's not case sensitive).
    https://www.evernote.com/shard/s744/u/0/sh/4d270d00-353e-40fd-a0bb-0d837262f80a/454edd6b63bd16a7555fa995a86135e2

If we pass array('Term A', 'Term B', 'Term C', 'term A') Just the first three terms should be added

rajanvijayan added a commit that referenced this issue Aug 28, 2018
@ghost ghost added In Progress Workflow Label: Current in progress and removed Current Sprint Workflow Label: Should be done this sprint labels Aug 28, 2018
rajanvijayan added a commit that referenced this issue Aug 28, 2018
@rajanvijayan
Copy link
Contributor

@sudar I have to fix this issue #502

@sudar
Copy link
Owner

sudar commented Aug 29, 2018

@rajanit2000

Terms are not case sensitive in WordPress.

If you pass Term A and term A, then it should create two terms.

@sudar sudar added Current Sprint Workflow Label: Should be done this sprint and removed In Progress Workflow Label: Current in progress labels Sep 2, 2018
@sudar sudar assigned sudar and unassigned rajanvijayan Sep 2, 2018
@esudalaimadan esudalaimadan changed the title DeleteTermsByNameModuleTest fails for the 'not_equal_to' dataset DeleteTermsByNameModuleTest fails for the 'not_equal_to' and 'equal_to' datasets Sep 5, 2018
@sudar sudar closed this as completed Sep 22, 2018
@ghost ghost removed the Current Sprint Workflow Label: Should be done this sprint label Sep 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants