-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAKING] Refactor process creation, add enumerations and improve code readability #11
Draft
calien666
wants to merge
8
commits into
sudhaus7:main
Choose a base branch
from
calien666:migrate-datahandler
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calien666
force-pushed
the
migrate-datahandler
branch
from
May 16, 2024 20:39
fa9e86a
to
e6d5300
Compare
The commit is a major refactor that introduces enumerations to represent the creator's status, abstracts process creation into a separate service, and enhances code readability and organization. It also includes updates to composer dependencies and brings minor changes to various class files, improving overall code quality and maintainability. Changes involving deprecated items are also reflected. The update is part of an ongoing effort to streamline processes and improve code quality.
calien666
force-pushed
the
migrate-datahandler
branch
from
May 16, 2024 20:40
e6d5300
to
01a0147
Compare
calien666
changed the title
Refactor process creation, add enumerations and improve code readability
[BREAKING] Refactor process creation, add enumerations and improve code readability
May 16, 2024
The tt_content.php file has been deleted while ext_emconf.php and composer.json file have been updated. Changes include a updated extension description and removal of a redundant dependency. The category field for the 'Sudhaus7' Wizard has also been revised.
The PHPStan baseline file has been updated to include new error messages for different classes and methods. The PHPStan static analysis level has also been significantly reduced from 8 to 5, leading to less stringent checks.
Updated the Services.php configuration file to exclude the Domain/Dto directory from service loads. This change ensures that classes within the directory do not interfere with the auto loading mechanism of the Services.
A new .gitattributes file has been added to the project. Several folders and files have been set to be ignore during exports. Additionally, end-of-line settings have been strictly defined for various file extensions in order to maintain consistency across different platforms.
The references to WizardProcessInterface across various classes have been updated. Several new events have been created, which are significant for components of both the create process and the cleaning process. A new Service has been added to handle the process events, and additional changes were made to improve functionality.
A 'fileMount' property with getter and setter methods was added to the AbstractCreateProcess and CreateProcessInterface classes. The ProcessService class was also updated to handle file mount creation in the 'run' method. Finally, a 'immediatelyAddRecord' was added in DataHandlingService for creating a record.
The ExtensionConfiguration class was added to improve configuration management with options such as defaultSiteSorter, groupPrefix, and unifyShortName. The ProcessService class was also improved with the addition of a method to create backend user groups. The CreateProcessInterface now includes setters for setting template backend group ID and main backend group.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit is a major refactor that introduces enumerations to represent the creator's status, abstracts process creation into a separate service, and enhances code readability and organization. It also includes updates to composer dependencies and brings minor changes to various class files, improving overall code quality and maintainability. Changes involving deprecated items are also reflected. The update is part of an ongoing effort to streamline processes and improve code quality.