-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loading state when awaiting llm responses #19
base: master
Are you sure you want to change the base?
Conversation
Thanks for the PR, give me some time to go through the code changes and get back with my feedback |
@sudo-vaibhav Sounds good, thanks |
@sudo-vaibhav Checking in to see if you’ve had a chance to review this PR. Thanks! |
This is a nice idea, and I appreciate this contribution. I see two ways ahead -
Maybe this second idea will create a subpar experience for individual components (maybe the maximum that we can achieve with this generic approach is putting a loader on the whole LLM container as a whole) but then cater to a much broader array of use cases. Since you have worked much more on this interesting problem and have done the cool hands-on work while implementing this LLM loader, do you have any inputs on how we might implement this loading concept once framework-wide, and then be able to make these individual component implementations of loaders in much fewer lines of code @hunter547 |
lgtm for now, merging to alpha, can prioritise refactoring later |
Good work @hunter547 , urge you to also raise a PR on the docs repo, so that people can be aware of how to use this new addition here: https://github.com/sudomakes/backroad-documentation/blob/main/src/content/docs/docs/API%20Reference/LLM.mdx |
I was noticing that backroad can only support synchronous llm responses, which is not a realistic scenario given llm requests don't provide immediate replies. This one was tough to implement and not sure this is the best strategy, but it gets the job done and looks great on the UI. Open to make changes, as I'm sure I didn't follow a pattern or two. Thanks