Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only for dnscheck.py #3

Closed
wants to merge 7 commits into from
Closed

only for dnscheck.py #3

wants to merge 7 commits into from

Conversation

stillson
Copy link

Just pick up dnscheck.py if you can. the rest is in progress and probable doesn't work

@max-b
Copy link
Member

max-b commented Mar 14, 2015

The garden isn't currently in use, so I think I'm going to hold off on any merges at the moment. I'd be much happier being able to merge in the whole thing when you're ready.

@stillson
Copy link
Author

That's fine. I think I just wanted to share the code :)

Chris

On Sat, Mar 14, 2015 at 8:57 AM, max-b notifications@github.com wrote:

The garden isn't currently in use, so I think I'm going to hold off on any
merges at the moment. I'd be much happier being able to merge in the whole
thing when you're ready.


Reply to this email directly or view it on GitHub
#3 (comment).

@max-b
Copy link
Member

max-b commented Mar 15, 2015

awesome - lookin good. I haven't had a chance to run it yet, but it's a lot cleaner...

@gobengo
Copy link
Contributor

gobengo commented Feb 22, 2018

this is so old. Can we close it?

@jhpoelen
Copy link
Contributor

@bennlich what do you think?

@bennlich
Copy link
Collaborator

It looks like this has to do with squid3 and the peoplesopen wifi splash screen. I don't think this splash screen exists anymore, but I don't really know anything about its history, or what in particular this PR is about.

If we've decided not to have a peoplesopen wifi splash screen, we should probably close this and delete all splash-screen-specific code in the firmware.

Maybe someone who knows more about this history can chime in? @paidforby @jnny @Juul ? I don't really know who to cc on this.

@bennlich
Copy link
Collaborator

bennlich commented Mar 5, 2018

Let's close. Too much trouble to figure out what it's about given very little explanation in the PR conversation itself. Also appears to be related to the captive portal / walled garden, which seem to be on nobody's Todo list atm.

@jhpoelen jhpoelen closed this Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants