Apply go vet and golint #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` chatwork_notifier.go:10:6: exported type ChatworkNotifier should have comment or be unexported chatwork_notifier.go:15:1: exported function NewChatworkNotifier should have comment or be unexported chatwork_notifier.go:22:1: exported method ChatworkNotifier.ExpectedKeys should have comment or be unexported chatwork_notifier.go:26:1: exported method ChatworkNotifier.PostStatus should have comment or be unexported config.go:8:6: exported type Config should have comment or be unexported config.go:10:1: exported function LoadConfigFromData should have comment or be unexported config.go:21:1: exported function LoadConfigFromFile should have comment or be unexported main.go:10:2: exported var Version should have comment or be unexported notifier.go:3:6: exported type PostStatusParam should have comment or be unexported notifier.go:10:6: exported type Notifier should have comment or be unexported slack_notifier.go:10:6: exported type SlackNotifier should have comment or be unexported slack_notifier.go:16:1: exported function NewSlackNotifier should have comment or be unexported slack_notifier.go:30:1: exported method SlackNotifier.ExpectedKeys should have comment or be unexported slack_notifier.go:34:1: exported method SlackNotifier.PostStatus should have comment or be unexported status_store.go:9:6: exported type StatusStore should have comment or be unexported status_store.go:14:2: exported const NOT_FOUND_KEY should have comment (or a comment on this block) or be unexported status_store.go:17:1: exported function NewStatusStore should have comment or be unexported status_store.go:23:1: exported method StatusStore.GetDbStatus should have comment or be unexported status_store.go:42:1: exported method StatusStore.SaveDbStatus should have comment or be unexported util.go:5:1: exported function GetStatusCode should have comment or be unexported util.go:16:1: exported function IsSuccessfulStatus should have comment or be unexported ```
…d be notifierType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.