Rebase with Upstream and Port to Python3 #7

Saumya-Mishra9129 · 2020-06-10T15:27:29Z

Twisted uses a module named 'attr' which I couldn't find in sugar . So I installed it manually using pip (apt-get didn't work) with following command-

sudo pip install attrs

Also we need to install OpenSSL with sudo apt-get install python3-openssl to get it working.

@chimosky @quozl @srevinsaju Please Review.

constantly source rebasing with https://github.com/twisted/constantly

incremental source rebasing with https://github.com/twisted/incremental

twisted source rebasing with https://github.com/twisted/twisted

Zope source rebasing with https://github.com/zopefoundation/zope.interface

srevinsaju · 2020-06-10T15:28:42Z

Nice; will review it now.
OMG: heavy diff

srevinsaju

Reviewing is tedious, 555 files from the last two commits. Some minor corrections; Will update you with sugar testing

afk_manager.py

chat_box.py

constantly/_constants.py

Saumya-Mishra9129 · 2020-06-10T15:46:54Z

Twisted uses a module named 'attr' which I couldn't find in sugar . So I installed it manually using pip (apt-get didn't work) with following command-
sudo pip install attrs

I now found out that we don't need to do this. It will get install when we run -
sudo apt-get install python3-service-identity It is in Readme.md

srevinsaju · 2020-06-10T15:47:22Z

Can we depend on distribution specific twisted and other packages? Need to consult others too.

this will probably reduce the work to be done. for example as has been done with Box2D in physics activity

Saumya-Mishra9129 · 2020-06-10T15:55:08Z

Can we depend on distribution specific twisted and other packages? Need to consult others too.

this will probably reduce the work to be done. for example as has been done with Box2D in physics activity

Yeah it is probably a good thing to be done. If others agree I will do that as well.

@Saumya-Mishra9129 are you defaultnick who is joining #sugar?

Yes I tried to join with Polari.
Got an error

srevinsaju · 2020-06-10T15:56:24Z

It is currently very buggy, the UI is better than IRC activity though; I can get to the UI, but can do nothing; Getting lots of repeated errors

builtins.UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe4 in position 127: invalid contin
uation byte

Its possible that some files used within is buggy or is a escape character; probably it was not encoded in the proper charset

Saumya-Mishra9129 · 2020-06-10T15:59:47Z

It is currently very buggy, the UI is better than IRC activity though; I can get to the UI, but can do nothing; Getting lots of repeated errors
builtins.UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe4 in position 127: invalid contin
uation byte
Its possible that some files used within is buggy or is a escape character; probably it was not encoded in the proper charset

The error is in while irc.py inside twisted, seems like after port to python3 because all strings are stored as Unicode in an instance of the str type, there can be bugs in twisted.

srevinsaju · 2020-06-10T16:01:16Z

Ok, I am not spamming #sugar any more;

seems like after port to python3 because unicode strings are not accepted, there is bugs in twisted.

Twisted is a good repository, and maintained. If there was an error, it should have been found out before. It seems like correct data types were not passed as parameters. It will require advance debugging however

Btw, there is a typo in PR title

Saumya-Mishra9129 · 2020-06-10T16:07:01Z

Twisted is a good repository, and maintained. If there was an error, it should have been found out before. It seems like correct data types were not passed as parameters. It will require advance debugging however

Yeah possible, I agree with you , It would need debugging of source code.

chimosky · 2020-06-10T23:18:29Z

@Saumya-Mishra9129 said

Yeah it is probably a good thing to be done. If others agree I will do that as well.

Yeah I agree, use distro specific packages where possible.

In setup.py cmd_genpot add --from-code=UTF-8 as part of your arguments to xgettext as an error is thrown by xgettext when trying to parse some strings in Python 3 if the encoding isn't specified.. See sugarlabs/sugar-toolkit-gtk3@ecf335c.

Didn't review cd8a53e...5814bac as I can't properly view the diff of the aggregate change.
I'll wait for you to use distro specific packages before reviewing.

support the use of distro specific packages

Based on sugarlabs/sugar-toolkit-gtk3@ecf335c

Saumya-Mishra9129 · 2020-06-11T19:37:46Z

Didn't review cd8a53e...5814bac as I can't properly view the diff of the aggregate change.
I'll wait for you to use distro specific packages before reviewing.

It is done.@chimosky Please review.

builtins.UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe4 in position 127: invalid contin
uation byte

I am not able to get the cause of this error. @quozl can you look once.

quozl · 2020-06-29T05:01:13Z

What do you need for the UnicodeDecodeError? Are all the source files UTF-8 encoded, and do they contain only UTF-8?

Fixes error seen while making connection. while sending a line , it takes channel as an encoded object. Unhandled Error Traceback (most recent call last): File "/usr/lib/python3/dist-packages/twisted/python/log.py", line 103, in callWithLogger return callWithContext({"system": lp}, func, *args, **kw) File "/usr/lib/python3/dist-packages/twisted/python/log.py", line 86, in callWithContext return context.call({ILogContext: newCtx}, func, *args, **kw) File "/usr/lib/python3/dist-packages/twisted/python/context.py", line 122, in callWithContext return self.currentContext().callWithContext(ctx, func, *args, **kw) File "/usr/lib/python3/dist-packages/twisted/python/context.py", line 85, in callWithContext return func(*args,**kw) --- <exception caught here> --- File "/usr/lib/python3/dist-packages/twisted/internet/posixbase.py", line 614, in _doReadOrWrite why = selectable.doRead() File "/usr/lib/python3/dist-packages/twisted/internet/tcp.py", line 243, in doRead return self._dataReceived(data) File "/usr/lib/python3/dist-packages/twisted/internet/tcp.py", line 249, in _dataReceived rval = self.protocol.dataReceived(data) File "/usr/lib/python3/dist-packages/twisted/words/protocols/irc.py", line 2631, in dataReceived basic.LineReceiver.dataReceived(self, data) File "/usr/lib/python3/dist-packages/twisted/protocols/basic.py", line 572, in dataReceived why = self.lineReceived(line) File "/usr/lib/python3/dist-packages/twisted/words/protocols/irc.py", line 2637, in lineReceived line = line.decode("utf-8") builtins.UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe4 in position 121: invalid continuation byte Tested with Ubuntu 20.04 and sucrose version 0.117

Saumya-Mishra9129 · 2020-07-08T15:13:59Z

Update - UnicodeDecodeError is fixed in d4b7c80. I have tested also works fine. @chimosky @srevinsaju @quozl Please Review.

quozl · 2020-07-09T05:02:18Z

Thanks.

Fixes #6

Polari upstream has changed from Python to JavaScript. But this code remains Python. When you say you rebased with upstream, what did you do?

Reviewed. Prepared a diffstat. Most of the change is to remove the embedded twisted, which is good.

Tested. Speaking on #sugar without registration gives no message. A message is sent to the client by the server but is not displayed.

Saumya-Mishra9129 · 2020-07-09T05:15:55Z

Polari upstream has changed from Python to JavaScript. But this code remains Python. When you say you rebased with upstream, what did you do?

By rebasing with upstream I thought of rebasing libraries used ( twisted , zope, incremental and constantly) with their upstream sources. So I first did that, but then @chimosky suggested to use distro specific twisted ,which I have done later.

Next step would be now to rebase with Polari upstream now probably??

quozl · 2020-07-09T05:36:24Z

I see, thanks. Our toolkit doesn't have support for JavaScript GObject Introspection apps, so rebasing Polari itself would be a major undertaking requiring new toolkit code as well. I don't think we need that yet. But you might check for changes to Polari between the time this source code was copied and before they switched to JavaScript.

That could be a separate pull request though.

Saumya-Mishra9129 · 2020-08-10T07:47:02Z

I see, thanks. Our toolkit doesn't have support for JavaScript GObject Introspection apps, so rebasing Polari itself would be a major undertaking requiring new toolkit code as well. I don't think we need that yet. But you might check for changes to Polari between the time this source code was copied and before they switched to JavaScript.

Thanks, for Polari source code, I couldn't find source code which was related to Python3 and also that's so old also.

That could be a separate pull request though.

Thanks I will make a different one. Until then you can merge these changes.

quozl · 2020-08-11T05:45:08Z

I've checked again, and I no longer think this activity has any association with the GNOME Polari app. Polari activity is an independent implementation using Twisted, and the name is coincidental.

Saumya-Mishra9129 added 9 commits June 10, 2020 16:32

change exec to sugar-activity3

0ab6dc3

Run 2to3

5266c80

Rebase with upstream constantly

cd8a53e

constantly source rebasing with https://github.com/twisted/constantly

Rebase with upstream : incremental

a7265a7

incremental source rebasing with https://github.com/twisted/incremental

Rebase with upstream : twisted

82fb127

twisted source rebasing with https://github.com/twisted/twisted

Rebase with upstream : Zope

5814bac

Zope source rebasing with https://github.com/zopefoundation/zope.interface

Change shebang to python3

d328f5f

TypeError : Item 0 : must be number not str

fae741e

TypeError: Item 0: must be number not str

c46c7db

srevinsaju suggested changes Jun 10, 2020

View reviewed changes

afk_manager.py Outdated Show resolved Hide resolved

afk_manager.py Outdated Show resolved Hide resolved

chat_box.py Outdated Show resolved Hide resolved

chat_box.py Outdated Show resolved Hide resolved

constantly/_constants.py Outdated Show resolved Hide resolved

Run 2to3

729ee17

This comment has been minimized.

Sign in to view

Saumya-Mishra9129 changed the title ~~Reabse with Upstream and Port to Python3~~ Rebase with Upstream and Port to Python3 Jun 10, 2020

Saumya-Mishra9129 added 6 commits June 11, 2020 23:18

Remove list function imported by 2to3

206d49f

Some PEP8 fixes

8340d23

Optimize imports

8470555

Remove zope, constantly, twisted, incremental

a4a227c

support the use of distro specific packages

Add --from-code parameter to xgettext for a python3 activity

7285b5e

Based on sugarlabs/sugar-toolkit-gtk3@ecf335c

Update Readme.md with Python3 commands and add python3-twisted

a581573

Saumya-Mishra9129 force-pushed the major branch from 0465076 to a581573 Compare June 11, 2020 18:39

Saumya-Mishra9129 force-pushed the major branch 2 times, most recently from 80869c5 to a581573 Compare July 8, 2020 11:06

Saumya-Mishra9129 force-pushed the major branch from 322f903 to d4b7c80 Compare July 8, 2020 15:11

quozl merged commit 8f1f126 into sugarlabs:master Aug 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rebase with Upstream and Port to Python3 #7

Rebase with Upstream and Port to Python3 #7

Saumya-Mishra9129 commented Jun 10, 2020

srevinsaju commented Jun 10, 2020 •

edited

Loading

srevinsaju left a comment

Saumya-Mishra9129 commented Jun 10, 2020

srevinsaju commented Jun 10, 2020 •

edited

Loading

This comment has been minimized.

Saumya-Mishra9129 commented Jun 10, 2020

srevinsaju commented Jun 10, 2020 •

edited

Loading

Saumya-Mishra9129 commented Jun 10, 2020 •

edited

Loading

srevinsaju commented Jun 10, 2020 •

edited

Loading

Saumya-Mishra9129 commented Jun 10, 2020 •

edited

Loading

chimosky commented Jun 10, 2020 •

edited

Loading

Saumya-Mishra9129 commented Jun 11, 2020 •

edited

Loading

quozl commented Jun 29, 2020

Saumya-Mishra9129 commented Jul 8, 2020

quozl commented Jul 9, 2020

Saumya-Mishra9129 commented Jul 9, 2020 •

edited

Loading

quozl commented Jul 9, 2020 •

edited

Loading

Saumya-Mishra9129 commented Aug 10, 2020

quozl commented Aug 11, 2020

Rebase with Upstream and Port to Python3 #7

Rebase with Upstream and Port to Python3 #7

Conversation

Saumya-Mishra9129 commented Jun 10, 2020

srevinsaju commented Jun 10, 2020 • edited Loading

srevinsaju left a comment

Choose a reason for hiding this comment

Saumya-Mishra9129 commented Jun 10, 2020

srevinsaju commented Jun 10, 2020 • edited Loading

This comment has been minimized.

Saumya-Mishra9129 commented Jun 10, 2020

srevinsaju commented Jun 10, 2020 • edited Loading

Saumya-Mishra9129 commented Jun 10, 2020 • edited Loading

srevinsaju commented Jun 10, 2020 • edited Loading

Saumya-Mishra9129 commented Jun 10, 2020 • edited Loading

chimosky commented Jun 10, 2020 • edited Loading

Saumya-Mishra9129 commented Jun 11, 2020 • edited Loading

quozl commented Jun 29, 2020

Saumya-Mishra9129 commented Jul 8, 2020

quozl commented Jul 9, 2020

Saumya-Mishra9129 commented Jul 9, 2020 • edited Loading

quozl commented Jul 9, 2020 • edited Loading

Saumya-Mishra9129 commented Aug 10, 2020

quozl commented Aug 11, 2020

srevinsaju commented Jun 10, 2020 •

edited

Loading

srevinsaju commented Jun 10, 2020 •

edited

Loading

srevinsaju commented Jun 10, 2020 •

edited

Loading

Saumya-Mishra9129 commented Jun 10, 2020 •

edited

Loading

srevinsaju commented Jun 10, 2020 •

edited

Loading

Saumya-Mishra9129 commented Jun 10, 2020 •

edited

Loading

chimosky commented Jun 10, 2020 •

edited

Loading

Saumya-Mishra9129 commented Jun 11, 2020 •

edited

Loading

Saumya-Mishra9129 commented Jul 9, 2020 •

edited

Loading

quozl commented Jul 9, 2020 •

edited

Loading