Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Metadata + Screenshots of Activities #7

Closed
wants to merge 7 commits into from

Conversation

mayankkuthar
Copy link

No description provided.

@@ -6,3 +6,7 @@ icon = activity-blockparty
activity_version = 8
license = MIT
show_launcher = yes
summary = https://github.com/sugarlabs/block-party-activity

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gabbar8055 Thanks for the patch.
The summary as described here should give a basic description of the activity. Please fill the appropriate metadata.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@vipulgupta2048
Copy link

Thanks. Good progress.
@Gabbar8055 Can you tell me how you reproduced the images? I don't understand the small size and the Sugar toolbar missing from the top.
@quozl Can you review further?

@mayankkuthar
Copy link
Author

Thanks @vipulgupta2048
I am using Vmware to run sugar on my system and captured screenshots from snipping tool.
The Sugar toolbar do not apper when you run the block party activity thats why its missing from top.

@quozl
Copy link
Contributor

quozl commented Dec 12, 2018

@Gabbar8055, thanks, reviewed. Please fix blurring.

@vipulgupta2048, thanks for mentioning me, I was not watching this repository.

@quozl
Copy link
Contributor

quozl commented Dec 12, 2018

@Gabbar8055, thanks, the blur is reduced.

I've compared against running the activity on Ubuntu 16.04 with Sugar 0.112.

  • there's no "Press ESC to exit" message on your screenshots, and I've no idea why; are you using the latest source code from the repository here or a bundle instead? The message was added in 6af29a1.
  • there's no initial screen; the one that has "SELECT LEVEL: $(n) enter to start",
  • there's a light blue horizontal bar at the top of your screenshots, but it doesn't happen when I run the activity,
  • the blur is still there around the edges of the blocks; yours;

your

mine;

mine

I understand you've finished GCI. I'm happy to take over from here, if you're busy with other things, just let me know.

@rhl-bthr
Copy link

Looks like @Gabbar8055 is busy

@quozl quozl closed this Jan 18, 2019
@tony37
Copy link

tony37 commented Jan 19, 2019 via email

@quozl
Copy link
Contributor

quozl commented Jan 20, 2019

Thanks for testing. None of what you say is relevant to this pull request, which was make-work to update metadata and screenshots as part of yet another attempt to replace ASLO. But it is relevant to issue #4, so I'll link that issue here just to add to the confusion.

Yes, BlockParty-7 does work with the much older OLPC OS builds which were based on earlier Sugar, but the reason it worked was that CSound provided a TCP/IP network server and the activity connected to the server to make sound. Later version of CSound in Fedora, which was adopted by later OLPC OS builds, removed that capability, probably for some unspecified security reason.

In order to remain operational, BlockParty is obliged to use CSound by direct API instead of network. That's what issue #4 is to track.

@tony37
Copy link

tony37 commented Jan 21, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants