Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use .format() for placing string variables inside strings #62

Open
davelab6 opened this issue Jul 9, 2016 · 1 comment
Open

Use .format() for placing string variables inside strings #62

davelab6 opened this issue Jul 9, 2016 · 1 comment
Assignees
@davelab6
Labels
Confirm fixed
Milestone
Someday/Maybe

Comments

@davelab6
Copy link
Contributor

davelab6 commented Jul 9, 2016 •
edited
Loading

custom_box.py#L21 has

    HEADING_STRING = "<span foreground='black' size='" + fontSize + "' font='Cantarell' font_weight='medium'>" + heading + "</span>"

and this style of string formatting is deprecated; it should be done with str.format()

    HEADING_STRING = "<span foreground='black' size='{}' font='Cantarell' \
    font_weight='medium'>{}</span>".format(fontSize, heading)

This isn't a pep8 error that flake8 can pick up (AFAIK) but something I'm aware of that we should make an effort to get right before the end of the GSOC :)
@davelab6 davelab6 added this to the Admin Tasks milestone Jul 9, 2016
@davelab6 davelab6 modified the milestones: Someday/Maybe, Admin Tasks Jul 30, 2016
@YashAgarwal YashAgarwal mentioned this issue Aug 6, 2016
Merged
davelab6 pushed a commit that referenced this issue Aug 6, 2016
@YashAgarwal @davelab6
Welcome Page UI (#88)
bbce0a9 
* removing the git submodules

* import otf, tf is now working

* creating welcome screen

* # This is a combination of 2 commits.
# The first commit's message is:

completing the welcome page UI

add user color to the icons
Fixes #32 
Fixes #35 
Fixes #62 
Fixes #82

add load, save, import, export buttons to the top bar

add buttons for welcome, manager, summary and editor pages (but note that on the welcome page these wont be active sometimes

Use a UFO of Geo with just 101 glyphs as the demo font Fixes #82

# The 2nd commit message will be skipped:

#	fixing some thing

* resolving conflicts
davelab6 pushed a commit that referenced this issue Aug 6, 2016
@YashAgarwal @davelab6
Welcome Page UI (#88)
83e2a17 
* removing the git submodules

* import otf, tf is now working

* creating welcome screen

* # This is a combination of 2 commits.
# The first commit's message is:

completing the welcome page UI

add user color to the icons
Fixes #32 
Fixes #35 
Fixes #62 
Fixes #82

add load, save, import, export buttons to the top bar

add buttons for welcome, manager, summary and editor pages (but note that on the welcome page these wont be active sometimes

Use a UFO of Geo with just 101 glyphs as the demo font Fixes #82

# The 2nd commit message will be skipped:

#	fixing some thing

* resolving conflicts
@davelab6 davelab6 self-assigned this Aug 6, 2016
@davelab6
Copy link
Contributor Author

davelab6 commented Aug 6, 2016

Reopening to confirm

@davelab6 davelab6 reopened this Aug 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davelab6 davelab6

Labels
Confirm fixed
Projects
None yet
Milestone
Someday/Maybe
Development

No branches or pull requests
1 participant
@davelab6